You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nlpcraft.apache.org by Aaron Radzinski <ar...@datalingvo.com> on 2020/09/30 17:58:10 UTC
[RESULT] [VOTE] Release Apache NLPCraft (Incubating) 0.7.0
NLPCraft-ers,
The vote for Apache NLPCraft 0.7.0 release is closed now.
Vote result: the vote PASSES with 8 votes +1 and no -1.
+1 votes:
- Nikita Ivanov
- Aaron Radzinski
- Sergey Kamov
- Gleb Ifrops
- Sergey Makov
- Furkan Kamaci (IPMC)
- Konstantin Boudnik (IPMC)
- Paul King (IPMC)
I will proceed with starting the final vote at IPMC shortly.
Thank you,
--
Aaron Radzinski
On Wed, Sep 30, 2020 at 8:07 AM Furkan KAMACI <fu...@gmail.com>
wrote:
> Hi,
>
> +1 from me.
>
> I checked:
>
> - Incubating in name
> - DISCLAIMER exists
> - LICENSE and NOTICE are fine
> - No unexpected binary files
> - Checked PGP signatures
> - Checked checksums
> - Code compiles
>
> Kind Regards,
> Furkan KAMACI
>
> On Tue, Sep 29, 2020 at 9:06 PM Konstantin Boudnik <co...@apache.org> wrote:
>
> > It is test issue at best which ain't invalidating the release, in my
> > opinion. Which seems to be solid otherwise, IMO.
> > --
> > With regards,
> > Cos
> >
> > On 2020-09-29 19:46, Nikita Ivanov wrote:
> > > Furkan - is this still "-1" from you? Seems like an env issue. If
> indeed
> > > necessary - team will re-cut the build with those changes and re-submit
> > for
> > > the vote. Please, let us know.
> > >
> > > Thanks,
> > > --
> > > Nikita Ivanov
> > >
> > >
> > >
> > > On Tue, Sep 29, 2020 at 5:03 AM Sergey Kamov <sk...@gmail.com>
> > wrote:
> > >
> > >> Yes, seems H2 server cannot be started because port is not available
> > >>
> > >> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed:
> > >> 0.185 s <<< FAILURE! - in
> > org.apache.nlpcraft.examples.sql.NCSqlExampleSpec
> > >> [ERROR] org.apache.nlpcraft.examples.sql.NCSqlExampleSpec Time
> > >> elapsed: 0.185 s <<< ERROR!
> > >> org.h2.jdbc.JdbcSQLException: Database
> > >> "/Users/kamaci/Desktop/sonarqube-8.4.2.36762/data/nlp2sql" not found,
> > >> and IFEXISTS=true, so we cant auto-create it [90146-197]
> > >> at
> > >>
> > >>
> >
> org.apache.nlpcraft.examples.sql.NCSqlExampleSpec.preProbeStart(NCSqlExampleSpec.scala:53)
> > >>
> > >> [INFO] Running org.apache.nlpcraft.examples.sql.NCSqlModelSpec
> > >> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> > >> elapsed: 0.001 s <<< FAILURE! - in
> > >> org.apache.nlpcraft.examples.sql.NCSqlModelSpec
> > >> [ERROR] org.apache.nlpcraft.examples.sql.NCSqlModelSpec Time
> > >> elapsed: 0 s <<< ERROR!
> > >> org.h2.jdbc.JdbcSQLException: Exception opening port "9092"
> (port
> > >> may be in use), cause: "java.net.BindException: Address already in use
> > >> (Bind failed)" [90061-197]
> > >> at
> > >>
> > >>
> >
> org.apache.nlpcraft.examples.sql.NCSqlModelSpec.preProbeStart(NCSqlModelSpec.scala:40)
> > >> Caused by: java.net.BindException: Address already in use (Bind
> > >> failed)
> > >> at
> > >>
> > >>
> >
> org.apache.nlpcraft.examples.sql.NCSqlModelSpec.preProbeStart(NCSqlModelSpec.scala:40)
> > >>
> > >> So, these 2 tests cannot be executed on your PC while port 9092 is not
> > >> accessible
> > >>
> > >>
> > >> Regards,
> > >>
> > >> Sergey Kamov
> > >>
> > >>
> > >>
> > >>
> > >>
> > >> 29.09.2020 14:41, Furkan KAMACI пишет:
> > >>> Hi,
> > >>>
> > >>> You can check the logs from here: https://paste.apache.org/yarzc
> > >>>
> > >>> Kind Regards,
> > >>> Furkan KAMACI
> > >>>
> > >>> On Tue, Sep 29, 2020 at 2:30 PM Sergey Kamov <sk...@gmail.com>
> > >> wrote:
> > >>>
> > >>>> Thank you.
> > >>>> Seems most of the problems disappeared.
> > >>>>
> > >>>> Remained errors - H2 sql server (which is necessary for sql model
> > >>>> test) cannot be started. Most possible reason is that port 9092 is
> > used
> > >>>> (for example by Kafka)
> > >>>> In next versions we'll change this port value to minimize possible
> > >>>> conflict situations.
> > >>>>
> > >>>> But anyway if tests are executed on user PC with some installed
> > software
> > >>>> - any conflicts are possible ..
> > >>>>
> > >>>> I guess we can skip checking these 2 remained tests for this
> release -
> > >>>> or please send us log (mvn clean verify > log.txt) to be sure that
> > >>>> reason is port or please try to run tests on another PC, or free
> 9092
> > >> port
> > >>>>
> > >>>> Thank you again
> > >>>>
> > >>>> Regards,
> > >>>> Sergey Kamov
> > >>>>> Hi,
> > >>>>>
> > >>>>> I've deleted it but get that error:
> > >>>>>
> > >>>>> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time
> > elapsed:
> > >>>>> 1.854 s - in
> > >>>>>
> > >>>>
> > >>
> >
> org.apache.nlpcraft.probe.mgrs.nlp.enrichers.model.NCEnricherNestedModelSpec
> > >>>>> [INFO]
> > >>>>> [INFO] Results:
> > >>>>> [INFO]
> > >>>>> [ERROR] Errors:
> > >>>>> [ERROR]
> > >>>>>
> > >>>>
> > >>
> >
> NCSqlExampleSpec>NCTestContext.beforeAll:42->NCTestContext.start0:73->preProbeStart:53
> > >>>>> » JdbcSQL
> > >>>>> [ERROR]
> > >>>>>
> > >>>>
> > >>
> >
> NCSqlModelSpec>NCTestContext.beforeAll:42->NCTestContext.start0:73->preProbeStart:40
> > >>>>> » JdbcSQL
> > >>>>> [INFO]
> > >>>>> [ERROR] Tests run: 58, Failures: 0, Errors: 2, Skipped: 1
> > >>>>> [INFO]
> > >>>>> [INFO]
> > >>>>>
> > >>
> ------------------------------------------------------------------------
> > >>>>> [INFO] Reactor Summary for NLPCraft Parent 0.7.0:
> > >>>>> [INFO]
> > >>>>> [INFO] NLPCraft Parent ....................................
> SUCCESS [
> > >>>>> 2.090 s]
> > >>>>> [INFO] NLPCraft ........................................... FAILURE
> > >>>> [04:28
> > >>>>> min]
> > >>>>> [INFO]
> > >>>>>
> > >>
> ------------------------------------------------------------------------
> > >>>>> [INFO] BUILD FAILURE
> > >>>>> [INFO]
> > >>>>>
> > >>
> ------------------------------------------------------------------------
> > >>>>> [INFO] Total time: 04:30 min
> > >>>>> [INFO] Finished at: 2020-09-29T12:53:42+03:00
> > >>>>> [INFO]
> > >>>>>
> > >>
> ------------------------------------------------------------------------
> > >>>>> [ERROR] Failed to execute goal
> > >>>>> org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test
> > >>>>> (integration-tests) on project nlpcraft: There are test failures.
> > >>>>>
> > >>>>> Kind Regards,
> > >>>>> Furkan KAMACI
> > >>>>>
> > >>>>> On Mon, Sep 28, 2020 at 11:08 PM Sergey Kamov <
> skhdlemail@gmail.com>
> > >>>> wrote:
> > >>>>>> hi Furkan!
> > >>>>>>
> > >>>>>> Did you have a chance to check version after deleting
> > >>>>>> /Users/kamaci/.nlpcraf? I hope it should help
> > >>>>>>
> > >>>>>>
> > >>>>>> Best regards,
> > >>>>>>
> > >>>>>> Sergey Kamov
> > >>>>>>
> > >>>>>> 26.09.2020 22:35, Sergey Kamov пишет:
> > >>>>>>> Hi!
> > >>>>>>> Thank you again
> > >>>>>>>
> > >>>>>>> I guess we forget to add instructions to clear previous version
> > data
> > >>>>>>> files, which structure were changed for last (0.7) version
> > >>>>>>>
> > >>>>>>> Could you
> > >>>>>>> - send us also some additional logs, which located under
> > >>>>>>>
> > >>
> <.../Downloads>/apache-nlpcraft/nlpcraft/target/server-${timestamp}.log
> > >>>>>>> - after, please drop your local folder
> /Users/kamaci/.nlpcraft
> > and
> > >>>>>>> re-start 'mvn clean verify'.
> > >>>>>>> Also send us please same two logs (tests results logs as
> > before
> > >> +
> > >>>>>>> apache-nlpcraft/nlpcraft/target/server-${timestamp}.log)
> > >>>>>>>
> > >>>>>>> If my suspicion is correct - we 'll ask all mentors to clear
> > the
> > >>>>>>> folder with old project data files before tests
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> Regards
> > >>>>>>> Sergey Kamov
> > >>>>>>>
> > >>>>>>> 26.09.2020 13:38, Furkan KAMACI пишет:
> > >>>>>>>> Hi Sergey,
> > >>>>>>>>
> > >>>>>>>> java -version
> > >>>>>>>> openjdk version "11.0.7" 2020-04-14
> > >>>>>>>> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10)
> > >>>>>>>> Eclipse OpenJ9 VM AdoptOpenJDK (build openj9-0.20.0, JRE 11 Mac
> > OS X
> > >>>>>>>> amd64-64-Bit Compressed References 20200417_552 (JIT enabled,
> AOT
> > >>>>>> enabled)
> > >>>>>>>> OpenJ9 - 05fa2d361
> > >>>>>>>> OMR - d4365f371
> > >>>>>>>> JCL - 838028fc9d based on jdk-11.0.7+10)
> > >>>>>>>>
> > >>>>>>>> Full tests execution logs are here:
> https://paste.apache.org/haia7
> > >>>>>> (yes, we
> > >>>>>>>> have a paste bin service at Apache :))
> > >>>>>>>>
> > >>>>>>>> Kind Regards,
> > >>>>>>>> Furkan KAMACI
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> On Sat, Sep 26, 2020 at 11:45 AM Sergey Kamov<
> > skhdlemail@gmail.com>
> > >>>>>> wrote:
> > >>>>>>>>> Hi
> > >>>>>>>>> Thank you for your time!
> > >>>>>>>>>
> > >>>>>>>>> I can't reproduce error under any environment.
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> When you have time could you send us
> > >>>>>>>>> - your java version (java -version)
> > >>>>>>>>> - full tests execution logs ? (mvn clean verify >
> log.txt)
> > >>>>>>>>>
> > >>>>>>>>> Regards
> > >>>>>>>>> Sergey Kamov
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> 26.09.2020 09:40, Furkan KAMACI пишет:
> > >>>>>>>>>> Hi,
> > >>>>>>>>>>
> > >>>>>>>>>> I get this error on MacOS with JDK 11:
> > >>>>>>>>>>
> > >>>>>>>>>> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> > >>>>>> elapsed:
> > >>>>>>>>>> 2.325 s <<< FAILURE! - in
> > >>>>>>>>>>
> > >>>>
> > >>
> >
> org.apache.nlpcraft.probe.mgrs.nlp.enrichers.model.NCEnricherNestedModelSpec
> > >>>>>>>>>> [ERROR] test Time elapsed: 0.248 s <<< ERROR!
> > >>>>>>>>>> org.scalatest.exceptions.TestFailedException:
> > >>>>>>>>>>
> > >>>>>>>>>> !!! Failed 2 from 3 tests. See errors list above. !!!
> > >>>>>>>>>>
> > >>>>>>>>>> at
> > >>>>>>>>>>
> > >>>>
> > >>
> >
> org.apache.nlpcraft.probe.mgrs.nlp.enrichers.model.NCEnricherNestedModelSpec.test(NCEnricherNestedModelSpec.scala:68)
> > >>>>>>>>>> [INFO]
> > >>>>>>>>>> [INFO] Results:
> > >>>>>>>>>> [INFO]
> > >>>>>>>>>> [ERROR] Failures:
> > >>>>>>>>>> [ERROR] NCTestExampleModelsSpec.test:44 See error logs
> above.
> > >> ==>
> > >>>>>>>>>> expected: <true> but was: <false>
> > >>>>>>>>>> [ERROR] NCConversationTimeoutSpec.test:108->ask$1:105
> > expected:
> > >>>>>> <true>
> > >>>>>>>>>> but was: <false>
> > >>>>>>>>>> [ERROR]
> > NCStmTestModelSpec.test:52->$anonfun$test$1:54->check:40
> > >>>>>>>>>> expected: <true> but was: <false>
> > >>>>>>>>>> [ERROR] Errors:
> > >>>>>>>>>> [ERROR] NCSqlExampleSpec.test:613->check:114 Test finished
> > with
> > >>>>>> errors
> > >>>>>>>>>> [passed=-1, fa...
> > >>>>>>>>>> [ERROR] NCSqlExampleSpec.testConversation:132->check:114
> Test
> > >>>>>> finished
> > >>>>>>>>>> with errors [p...
> > >>>>>>>>>> [ERROR]
> > >> NCSqlModelSpec.test:159->NCEnricherBaseSpec.runBatch:125 »
> > >>>>>>>>>> TestFailed
> > >>>>>>>>>> !!! Fai...
> > >>>>>>>>>> [ERROR] NCTimeModelSpec.testIntentsPriorities:47 »
> > NCTestClient
> > >>>>>>>>>> {"code":"NC_INVALID_FI...
> > >>>>>>>>>> [ERROR]
> > >>>>>> NCEnricherLimitSpec.test:51->NCEnricherBaseSpec.runBatch:125 »
> > >>>>>>>>>> TestFailed
> > >>>>>>>>>> !!!...
> > >>>>>>>>>> [ERROR]
> > >>>>>>>>>>
> > >> NCEnricherNestedModelSpec.test:68->NCEnricherBaseSpec.runBatch:125 »
> > >>>>>>>>>> TestFailed
> > >>>>>>>>>> [ERROR]
> > >>>>>> NCEnricherSortSpec.test:200->NCEnricherBaseSpec.runBatch:125 »
> > >>>>>>>>>> TestFailed
> > >>>>>>>>>> !!!...
> > >>>>>>>>>> [ERROR]
> > >>>>>>>>>>
> > >>>>
> > >>
> >
> NCRestAskSpec.testParameters:121->testAsk:152->NCRestSpec.post:178->NCRestSpec.post:189
> > >>>>>>>>>> » Runtime
> > >>>>>>>>>> [INFO]
> > >>>>>>>>>> [ERROR] Tests run: 59, Failures: 3, Errors: 8, Skipped: 1
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>> Kind Regards,
> > >>>>>>>>>> Furkan KAMACI
> > >>>>>>>>>>
> > >>>>>>>>>> On Thu, Sep 24, 2020 at 10:40 PM Sergey Makov<
> smakov@apache.org
> > >
> > >>>>>> wrote:
> > >>>>>>>>>>> +1
> > >>>>>>>>>>>
> > >>>>>>>>>>> Checked on MacOS only:
> > >>>>>>>>>>> - mvn clean package verify (JDK 11)
> > >>>>>>>>>>> - signatures
> > >>>>>>>>>>>
> > >>>>>>>>>>> Thanks,
> > >>>>>>>>>>> Sergey
> > >>>>>>>>>>>
> > >>>>>>>>>>> On Thu, Sep 24, 2020 at 9:35 PM Nikita Ivanov<
> > >> nivanov30@gmail.com>
> > >>>>>>>>> wrote:
> > >>>>>>>>>>>> Dear mentors - can we please get you to vote on the release?
> > >>>>>>>>>>>> Thanks!
> > >>>>>>>>>>>> --
> > >>>>>>>>>>>> Nikita Ivanov
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> On Wed, Sep 23, 2020 at 1:38 PM Sergey Kamov<
> > >> skhdlemail@gmail.com
> > >>>>>>>>>>> wrote:
> > >>>>>>>>>>>>> +1
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> - files checked
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> - mvn clean verify checked (mac, jdk11)
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> - examples and tests checked
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> Regards,
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> Sergey Kamov
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> 22.09.2020 22:35, Aaron Radzinski пишет:
> > >>>>>>>>>>>>>> NLPCraft-ers,
> > >>>>>>>>>>>>>> This is a call for a vote to release Apache NLPCraft
> > >>>> (incubating)
> > >>>>>>>>>>> version
> > >>>>>>>>>>>>>> 0.7.0. This release includes the final fix for the
> > >> configuration
> > >>>>>>>>>>> (which
> > >>>>>>>>>>>>> is
> > >>>>>>>>>>>>>> now downloadable) as well as the host of new features and
> > >>>>>> stability
> > >>>>>>>>>>>>>> improvements.
> > >>>>>>>>>>>>>>
> > >>>>>>>>>>>>>> Release information:
> > >>>>>>>>>>>>>> 1. Release location:
> > >>>>>>>>>>>>>>
> > >>>>
> > >>
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.0/
> > >>>>>>>>>>>>>> 3. Git tag:
> > >>>>>> https://github.com/apache/incubator-nlpcraft/tree/v0.7.0
> > >>>>>>>>>>>>>> 4. JIRA issues fixed in release:
> > >>>>>>>>>>>>>>
> > >>>>>>
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347776
> > >>>>>>>>>>>>>> 5. KEYS file:
> > >>>>>>>>>>>>>>
> > >>>>>>
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> > >>>>>>>>>>>>>> The vote will be open for at least 72 hours or until a
> > >> necessary
> > >>>>>>>>>>> number
> > >>>>>>>>>>>>> of
> > >>>>>>>>>>>>>> votes are reached.
> > >>>>>>>>>>>>>>
> > >>>>>>>>>>>>>> Please vote accordingly:
> > >>>>>>>>>>>>>> [ ] +1 approve
> > >>>>>>>>>>>>>> [ ] +0 no opinion
> > >>>>>>>>>>>>>> [ ] -1 disapprove with the reason
> > >>>>>>>>>>>>>>
> > >>>>>>>>>>>>>> Thank you,
> > >>>>>>>>>>>>>> Aaron (NLPCraft community).
> > >>>>>>>>>>>>>>
> > >>
> > >
> >
>