You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Michael Kurz (JIRA)" <de...@myfaces.apache.org> on 2007/10/17 19:27:50 UTC

[jira] Created: (MYFACES-1746) Properties not set in UIComponentTag.createComponent()

Properties not set in UIComponentTag.createComponent()
------------------------------------------------------

                 Key: MYFACES-1746
                 URL: https://issues.apache.org/jira/browse/MYFACES-1746
             Project: MyFaces Core
          Issue Type: Bug
    Affects Versions: 1.2.1-SNAPSHOT
            Reporter: Michael Kurz
             Fix For: 1.2.1-SNAPSHOT
         Attachments: myfaces-api-1746.patch

I ran into a problem with MyFaces 1.2.1-SNAPSHOT and Tomahawk 1.1.6. The problem was that for <t:commandButton id="cancel" value="Cancel" action="#{aBean.cancel}" /> no value was rendered and that the action was not working. With 1.2.0 it worked.

After some debugging I found out that setProperties() is not called in UICompnentTag.createComponent(). In 1.2.0 setProperties was called in UIComponentClassicTagBase.findComponent().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MYFACES-1746) Properties not set in UIComponentTag.createComponent()

Posted by "Michael Kurz (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Kurz updated MYFACES-1746:
----------------------------------

    Status: Patch Available  (was: Open)

> Properties not set in UIComponentTag.createComponent()
> ------------------------------------------------------
>
>                 Key: MYFACES-1746
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1746
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 1.2.1-SNAPSHOT
>            Reporter: Michael Kurz
>             Fix For: 1.2.1-SNAPSHOT
>
>         Attachments: myfaces-api-1746.patch
>
>
> I ran into a problem with MyFaces 1.2.1-SNAPSHOT and Tomahawk 1.1.6. The problem was that for <t:commandButton id="cancel" value="Cancel" action="#{aBean.cancel}" /> no value was rendered and that the action was not working. With 1.2.0 it worked.
> After some debugging I found out that setProperties() is not called in UICompnentTag.createComponent(). In 1.2.0 setProperties was called in UIComponentClassicTagBase.findComponent().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (MYFACES-1746) Properties not set in UIComponentTag.createComponent()

Posted by Martin Marinschek <ma...@gmail.com>.
Yeah, I set you as an assignee, because it was you who provided the fix.

Well, one always learns by digging, right?

regards,

Martin

On 10/26/07, Mario Ivankovits <ma...@ops.co.at> wrote:
> Hi!
> >      [
> https://issues.apache.org/jira/browse/MYFACES-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
> >
> > Martin Marinschek updated MYFACES-1746:
> > ---------------------------------------
> >
> >     Resolution: Fixed
> >       Assignee: Mario Ivankovits
> >         Status: Resolved  (was: Patch Available)
> >
> I think you set the Assignee now, didn't you? I wasn't aware that somone
> else already uncovered _AND FIXED_ this bug. Fine that we found the same
> solution - to find something positiv in spending some time to dig into
> stuff I never wanted to dig into ;-)
>
> Ciao,
> Mario
>
>


-- 

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

Re: [jira] Updated: (MYFACES-1746) Properties not set in UIComponentTag.createComponent()

Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi!
>      [ https://issues.apache.org/jira/browse/MYFACES-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Martin Marinschek updated MYFACES-1746:
> ---------------------------------------
>
>     Resolution: Fixed
>       Assignee: Mario Ivankovits
>         Status: Resolved  (was: Patch Available)
>   
I think you set the Assignee now, didn't you? I wasn't aware that somone 
else already uncovered _AND FIXED_ this bug. Fine that we found the same 
solution - to find something positiv in spending some time to dig into 
stuff I never wanted to dig into ;-)

Ciao,
Mario


[jira] Updated: (MYFACES-1746) Properties not set in UIComponentTag.createComponent()

Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Marinschek updated MYFACES-1746:
---------------------------------------

    Resolution: Fixed
      Assignee: Mario Ivankovits
        Status: Resolved  (was: Patch Available)

Hi Michael,

thanks for this patch - as I took such a long time, Mario beat me to it and committed a patch himself.

regards,

Martin

> Properties not set in UIComponentTag.createComponent()
> ------------------------------------------------------
>
>                 Key: MYFACES-1746
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1746
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 1.2.1-SNAPSHOT
>            Reporter: Michael Kurz
>            Assignee: Mario Ivankovits
>             Fix For: 1.2.1-SNAPSHOT
>
>         Attachments: myfaces-api-1746.patch
>
>
> I ran into a problem with MyFaces 1.2.1-SNAPSHOT and Tomahawk 1.1.6. The problem was that for <t:commandButton id="cancel" value="Cancel" action="#{aBean.cancel}" /> no value was rendered and that the action was not working. With 1.2.0 it worked.
> After some debugging I found out that setProperties() is not called in UICompnentTag.createComponent(). In 1.2.0 setProperties was called in UIComponentClassicTagBase.findComponent().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.