You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/27 15:03:16 UTC

[GitHub] [spark] sarutak edited a comment on pull request #34111: [SPARK-36856][BUILD] Get correct JAVA_HOME for macOS

sarutak edited a comment on pull request #34111:
URL: https://github.com/apache/spark/pull/34111#issuecomment-927948334


   > Just the existing tests.
   
   It's not enough for this change because our CIs don't run on macOS. So, please make sure your change works on your environment and note how you have checked in the description next time.
   This time, I'm checking with `build/mvn -DskipTests package` on my Big Sur.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org