[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4412: Remove 64-bit to 32-bit Cast from IPC Reader

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4412:
URL: https://github.com/apache/arrow-rs/pull/4412#discussion_r1230489562


##########
arrow-ipc/src/reader.rs:
##########
@@ -250,24 +242,23 @@ fn create_primitive_array(
         | UInt32
         | Time32(_)
         | Date32
-        | Interval(IntervalUnit::YearMonth) => {
-            if buffers[1].len() / 8 == length && length != 1 {

Review Comment:
   I'm surprised that the C++ IPC isn't truncating slices, but if it isn't I can see how that would cause issues



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org