You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/13 01:21:06 UTC

Review Request 24619: Made value in CommandInfo optional and added argv.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24619/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  include/mesos/mesos.proto cc9f20e 

Diff: https://reviews.apache.org/r/24619/diff/


Testing
-------


Thanks,

Jie Yu

Re: Review Request 24619: Made value in CommandInfo optional and added argv.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24619/#review50393
-----------------------------------------------------------


Could you include more information in the summary about the motivation? :)
For API changes so close to a cut, we should probably have a few eyes on it too.

This has come up before, be sure to take a look at the approach by Jason here: https://reviews.apache.org/r/15542/

Notably, the path and arguments were split apart, in a similar manner to how execv works. We also didn't need the boolean as you have in your patch here. Curious to hear your thoughts on that.

- Ben Mahler


On Aug. 12, 2014, 11:21 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24619/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 11:21 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto cc9f20e 
> 
> Diff: https://reviews.apache.org/r/24619/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24619: Made value in CommandInfo optional and added argv.

Posted by Timothy Chen <tn...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24619/#review50386
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Aug. 12, 2014, 11:21 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24619/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 11:21 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto cc9f20e 
> 
> Diff: https://reviews.apache.org/r/24619/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24619: Made value in CommandInfo optional and added argv.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24619/#review50476
-----------------------------------------------------------


A few notes since we're going to cut 0.20.0 and this is an API change!


include/mesos/mesos.proto
<https://reviews.apache.org/r/24619/#comment88282>

    It's not clear why we need the boolean 'shell', since the non-emptiness of 'argv' should indicate a preference to use that over 'value'. If there's some reason we need the boolean (e.g. Docker implementation leaking in here) we should add a small note. Is it possible to have an empty 'argv'?
    
    Curious, is a boolean enough or do you want a Type enum here?
    
    Is it true that we'll be using 'execve'? Seems like we just might want to outline the two styles of running commands taking inspiration from Subprocess: https://docs.python.org/2/library/subprocess.html#subprocess.Popen



include/mesos/mesos.proto
<https://reviews.apache.org/r/24619/#comment88290>

    s/argv/arguments/
    
    'argv' seems to be a historical name coming from the c 'argc' (count) 'argv' (vector) argument passing technique. Seems like we should avoid it by just calling this "arguments" since we avoid abbreviations as well.
    
    Maybe a small example to indicate that the program name is expected to be included here.


- Ben Mahler


On Aug. 12, 2014, 11:21 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24619/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 11:21 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto cc9f20e 
> 
> Diff: https://reviews.apache.org/r/24619/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jie Yu
> 
>