You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/07/27 17:09:13 UTC
[GitHub] [qpid-dispatch] ChugR opened a new pull request #1327: DISPATCH-2214: Reduce logging in tcp_adaptor self test
ChugR opened a new pull request #1327:
URL: https://github.com/apache/qpid-dispatch/pull/1327
* Put restraints on echo tests startup wait loop
Only poll N times; delay between polls
* Print qdsdat address displays if polling fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1327: DISPATCH-2214: Reduce logging in tcp_adaptor self test
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1327:
URL: https://github.com/apache/qpid-dispatch/pull/1327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1327: DISPATCH-2214: Reduce logging in tcp_adaptor self test
Posted by GitBox <gi...@apache.org>.
jiridanek commented on a change in pull request #1327:
URL: https://github.com/apache/qpid-dispatch/pull/1327#discussion_r678070407
##########
File path: tests/system_tests_tcp_adaptor.py
##########
@@ -528,6 +530,15 @@ def router(name, mode, connection, extra=None):
unseen = [srv for srv in cls.router_order if "ES_" + srv not in seen]
cls.logger.log("TCP_TEST Router %s sees only %d of %d addresses. Waiting for %s" %
(rtr, len(server_lines), len(cls.router_order), unseen))
+ if poll_loops == 1:
+ # last poll loop
+ for line in lines:
+ cls.logger.log("TCP_TEST Router %s : %s" % (rtr, line))
+ poll_loops -= 1
+ if poll_loops == 0:
+ assert False, "TCP_TEST TCP_Adaptor test setup failed. Echo tests never executed."
Review comment:
```suggestion
self.fail("TCP_TEST TCP_Adaptor test setup failed. Echo tests never executed.")
```
https://docs.python.org/3/library/unittest.html#unittest.TestCase.fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org