You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2017/05/02 16:50:53 UTC
[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6780
Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................
[webui] Fix master reg formatting and add memory use percentage.
This is a little patch to fix the formatting of the master
registration. I'd done this for tserver registrations before but
forgot /masters. It also adds a % memory consumed row to
the "Process memory usage" table on /mem-trackers.
Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/server/default-path-handlers.cc
2 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/6780/1
--
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6780
to look at the new patch set (#4).
Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................
[webui] Fix master reg formatting and add memory use percentage.
This is a little patch to fix the formatting of the master
registration. I'd done this for tserver registrations before but
forgot /masters. It also adds a % memory consumed row to
the "Process memory usage" table on /mem-trackers.
Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/server/default-path-handlers.cc
2 files changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/6780/4
--
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6780
to look at the new patch set (#3).
Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................
[webui] Fix master reg formatting and add memory use percentage.
This is a little patch to fix the formatting of the master
registration. I'd done this for tserver registrations before but
forgot /masters. It also adds a % memory consumed row to
the "Process memory usage" table on /mem-trackers.
Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/server/default-path-handlers.cc
2 files changed, 11 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/6780/3
--
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................
[webui] Fix master reg formatting and add memory use percentage.
This is a little patch to fix the formatting of the master
registration. I'd done this for tserver registrations before but
forgot /masters. It also adds a % memory consumed row to
the "Process memory usage" table on /mem-trackers.
Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Reviewed-on: http://gerrit.cloudera.org:8080/6780
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Will Berkeley <wd...@gmail.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/server/default-path-handlers.cc
2 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Will Berkeley: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6780/3/src/kudu/server/default-path-handlers.cc
File src/kudu/server/default-path-handlers.cc:
PS3, Line 160: *output << Substitute(" <tr><th>Percentage consumed</th><td>$0%</td></tr>\n",
: StringPrintf("%.2f", percentage));
nit: is it worth putting this under if (hard_limit > 0) clause?
--
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................
Patch Set 4: Verified+1
Overriding Jenkins- unrelated failure.
--
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6780/1/src/kudu/server/default-path-handlers.cc
File src/kudu/server/default-path-handlers.cc:
Line 157: StringPrintf("%.2f", 100 * (double) current_consumption / hard_limit));
> warning: C-style casts are discouraged; use static_cast [google-readability
Done
--
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has uploaded a new patch set (#2).
Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................
[webui] Fix master reg formatting and add memory use percentage.
This is a little patch to fix the formatting of the master
registration. I'd done this for tserver registrations before but
forgot /masters. It also adds a % memory consumed row to
the "Process memory usage" table on /mem-trackers.
Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/server/default-path-handlers.cc
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/6780/2
--
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [webui] Fix master reg formatting and add memory use percentage.
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6780/3/src/kudu/server/default-path-handlers.cc
File src/kudu/server/default-path-handlers.cc:
PS3, Line 160: *output << Substitute(" <tr><th>Percentage consumed</th><td>$0%</td></tr>\n",
: StringPrintf("%.2f", percentage));
> nit: is it worth putting this under if (hard_limit > 0) clause?
Done
--
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes