[GitHub] [flink] wsry commented on a diff in pull request #19653: [FLINK-27523] Runtime supports producing and consuming cached intermediate results

[GitBox <gi...@apache.org>]

wsry commented on code in PR #19653:
URL: https://github.com/apache/flink/pull/19653#discussion_r876570257


##########
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java:
##########
@@ -84,6 +86,33 @@ CompletableFuture<T> registerPartitionWithProducer(
             PartitionDescriptor partitionDescriptor,
             ProducerDescriptor producerDescriptor);
 
+    /**
+     * Returns all the shuffle descriptors for the partitions in the intermediate data set with the
+     * given id.
+     *
+     * @param intermediateDataSetID The id of the intermediate data set.
+     * @return all the shuffle descriptors for the partitions in the intermediate data set. Null if
+     *     not exist.
+     */
+    default Collection<T> getClusterPartitionShuffleDescriptors(
+            IntermediateDataSetID intermediateDataSetID) {
+        return Collections.emptyList();
+    }
+
+    /**
+     * Promote the given partition to cluster partition.
+     *
+     * @param shuffleDescriptor The shuffle descriptors of the partition to promote.
+     */
+    default void promotePartition(ShuffleDescriptor shuffleDescriptor) {}
+
+    /**
+     * Remove the given partition from cluster partition.
+     *
+     * @param shuffleDescriptor The shuffle descriptors of the cluster partition to be removed.
+     */
+    default void removeClusterPartition(ShuffleDescriptor shuffleDescriptor) {}

Review Comment:
   What's the difference of this method and the below one (releasePartitionExternally)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org