You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Xiangrui Meng (JIRA)" <ji...@apache.org> on 2015/04/30 02:27:06 UTC
[jira] [Resolved] (SPARK-7176) Add validation functionality to
individual Param
[ https://issues.apache.org/jira/browse/SPARK-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiangrui Meng resolved SPARK-7176.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.4.0
Issue resolved by pull request 5740
[https://github.com/apache/spark/pull/5740]
> Add validation functionality to individual Param
> ------------------------------------------------
>
> Key: SPARK-7176
> URL: https://issues.apache.org/jira/browse/SPARK-7176
> Project: Spark
> Issue Type: Sub-task
> Components: ML
> Reporter: Joseph K. Bradley
> Assignee: Joseph K. Bradley
> Fix For: 1.4.0
>
>
> This issue was brought up by [https://issues.apache.org/jira/browse/SPARK-7147]: There are multiple locations in which a parameter can be specified (in setters and in calling fit/transform), and we should check the parameter value in each one. It would be nice to avoid duplicating the checking code.
> Proposed change:
> * Add field to class Param: {{val isValid: T => Boolean}}, with default value of always returning true
> * Add helper methods in new ParamCheck object for constructing common validation checks (especially to help Java users)
> * Ensure that this validation is always done, most likely by always settings parameters by constructing a ParamPair + validating inside the ParamPair constructor
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org