You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by no...@apache.org on 2014/04/06 12:12:48 UTC
svn commit: r1585274 -
/lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/OverseerRolesTest.java
Author: noble
Date: Sun Apr 6 10:12:47 2014
New Revision: 1585274
URL: http://svn.apache.org/r1585274
Log:
SOLR-5859 Fixing test errors
Modified:
lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/OverseerRolesTest.java
Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/OverseerRolesTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/OverseerRolesTest.java?rev=1585274&r1=1585273&r2=1585274&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/OverseerRolesTest.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/OverseerRolesTest.java Sun Apr 6 10:12:47 2014
@@ -90,8 +90,8 @@ public class OverseerRolesTest extends
@Override
public void doTest() throws Exception {
- testOverseerRole();
testQuitCommand();
+ testOverseerRole();
}
@@ -109,11 +109,11 @@ public class OverseerRolesTest extends
String s = (String) m.get("id");
String leader = LeaderElector.getNodeName(s);
Overseer.getInQueue(zk).offer(ZkStateReader.toJSON(new ZkNodeProps(Overseer.QUEUE_OPERATION, Overseer.QUIT)));
- long timeout = System.currentTimeMillis()+5000;
+ long timeout = System.currentTimeMillis()+10000;
String newLeader=null;
for(;System.currentTimeMillis() < timeout;){
newLeader = OverseerCollectionProcessor.getLeaderNode(zk);
- if(!newLeader.equals(leader)) break;
+ if(newLeader!=null && !newLeader.equals(leader)) break;
Thread.sleep(100);
}
assertNotSame( "Leader not changed yet",newLeader,leader);
@@ -196,13 +196,16 @@ public class OverseerRolesTest extends
Matcher m = pattern.matcher(currentOverseer);
JettySolrRunner stoppedJetty =null;
+ String hostPort = null;
+ StringBuilder sb = new StringBuilder();
if(m.matches()){
- String hostPort = m.group(1)+":"+m.group(2);
+ hostPort = m.group(1)+":"+m.group(2);
log.info("hostPort : {}", hostPort);
for (JettySolrRunner jetty : jettys) {
String s = jetty.getBaseUrl().toString();
+ sb.append(s).append(" , ");
if(s.contains(hostPort)){
log.info("leader node {}",s);
ChaosMonkey.stop(jetty);
@@ -222,23 +225,28 @@ public class OverseerRolesTest extends
}
+ } else{
+ fail("pattern didn't match for"+currentOverseer );
}
- ChaosMonkey.start(stoppedJetty);
+ if(stoppedJetty !=null) {
+ ChaosMonkey.start(stoppedJetty);
- timeout = System.currentTimeMillis()+10000;
- leaderchanged = false;
- for(;System.currentTimeMillis() < timeout;){
- List<String> sortedNodeNames = getSortedOverseerNodeNames(client.getZkStateReader().getZkClient());
- if(sortedNodeNames.get(1).equals(killedOverseer) || sortedNodeNames.get(0).equals(killedOverseer)){
- leaderchanged =true;
- break;
+ timeout = System.currentTimeMillis() + 10000;
+ leaderchanged = false;
+ for (; System.currentTimeMillis() < timeout; ) {
+ List<String> sortedNodeNames = getSortedOverseerNodeNames(client.getZkStateReader().getZkClient());
+ if (sortedNodeNames.get(1).equals(killedOverseer) || sortedNodeNames.get(0).equals(killedOverseer)) {
+ leaderchanged = true;
+ break;
+ }
+ Thread.sleep(100);
}
- Thread.sleep(100);
- }
-
- assertTrue("New overseer not the frontrunner : "+ getSortedOverseerNodeNames(client.getZkStateReader().getZkClient()) + " expected : "+ killedOverseer, leaderchanged);
+ assertTrue("New overseer not the frontrunner : " + getSortedOverseerNodeNames(client.getZkStateReader().getZkClient()) + " expected : " + killedOverseer, leaderchanged);
+ } else {
+ log.warn("The jetty where the overseer {} is running could not be located in {}",hostPort,sb);
+ }
}
private void setOverseerRole(CollectionAction action, String overseerDesignate) throws Exception, IOException {