[GitHub] [flink] rkhachatryan commented on a diff in pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend

["rkhachatryan (via GitHub)" <gi...@apache.org>]

rkhachatryan commented on code in PR #21914:
URL: https://github.com/apache/flink/pull/21914#discussion_r1125727845


##########
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java:
##########
@@ -364,6 +364,7 @@ public Collection<String> getAllHandles() throws Exception {
                     return client.getChildren().forPath(path);
                 } catch (KeeperException.NoNodeException ignored) {
                     // Concurrent deletion, retry
+					LOG.warn("NoNodeException happend, and retrying again.");

Review Comment:
   > we offten occur zk leader change when zxid over it's range, get the message can tell us in time.
   
   It looks like the change is needed to **debug** the issues in a specific ZK-Flink setup, rather than in Flink itself.
   So I'd suggest to log it on `debug` level:
   
   ```suggestion
                   } catch (KeeperException.NoNodeException e) {
   					LOG.debug("Unable to get all handles, retrying (ZNode was likely deleted concurrently: {})", e.getMessage());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org