You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/02/15 15:56:45 UTC
[GitHub] cordova-android pull request: CB-10618 Handle gradle frameworks on...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/259
CB-10618 Handle gradle frameworks on plugin installation/uninstallation
An implementation for [CB-10618](https://issues.apache.org/jira/browse/CB-10618)
This PR brings into platform logic for processing gradle files after plugin installation (instead of keeping it in LIB).
It also removes `prepBuildFiles` method from `build` module exports, and by this disables this logic being called from LIB (as there is a check for `build.prepBuildFiles` existence - see https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/install.js#L625)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android CB-10618
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #259
----
commit 673150ccde2fcc8f7c4305d6f51dc24341330cf5
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-02-15T13:18:44Z
CB-10618 Handle gradle frameworks on plugin installation/uninstallation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10618 Handle gradle frameworks on...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10618 Handle gradle frameworks on...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/259#issuecomment-185239609
@nikhilkh, added tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10618 Handle gradle frameworks on...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/259#issuecomment-184778783
LGTM. How can we add tests for this scenario?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org