[GitHub] [arrow] js8544 commented on a diff in pull request #36891: GH-28481: [C++][Python] Add adjoin_as_list function

["js8544 (via GitHub)" <gi...@apache.org>]

js8544 commented on code in PR #36891:
URL: https://github.com/apache/arrow/pull/36891#discussion_r1275041966


##########
cpp/src/arrow/array/util.cc:
##########
@@ -538,7 +538,7 @@ class NullArrayFactory {
       out_->buffers.resize(3);
       out_->buffers[2] = buffer_;
 
-      child_length = 1;
+      child_length = length_ > 0 ? 1 : 0;

Review Comment:
   Function executor would call MakeNullArray with length zero when the input length is zero. The current implementation of MakeNullArray has a bug when the type is `list(dense_union(string))`, which is fixed by this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org