[GitHub] [beam] MakarkinSAkvelon commented on a diff in pull request #25994: Update of GKE deployment

["MakarkinSAkvelon (via GitHub)" <gi...@apache.org>]

MakarkinSAkvelon commented on code in PR #25994:
URL: https://github.com/apache/beam/pull/25994#discussion_r1168883186


##########
playground/terraform/infrastructure/appengine/variables.tf:
##########
@@ -36,3 +36,13 @@ variable "location_id_us" {
   description = "Location of App"
   default = "us-central"
 }
+
+variable "location_id_eu" {
+  description = "Location of App"
+  default = "europe-west"
+}
+
+variable "feature_flag" {

Review Comment:
   "feature_flag" was renamed to "skip_appengine_deploy".
   AppEngine can be deployed only once per project, and if we need to deploy additional environment, AppEngine should not be enabled once again (of other case we will get an error from Terraform)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org