[GitHub] [pulsar] srkukarni opened a new pull request #3861: Use `INSERTPULSARKEY_` for appending new keys

[GitBox <gi...@apache.org>]

srkukarni opened a new pull request #3861: Use `INSERTPULSARKEY_` for appending new keys
URL: https://github.com/apache/pulsar/pull/3861
 
 
   
   ### Motivation
   Motivation
   
   Currently integration tests are broken due to #3827
   
   PULSAR_ is used almost everywhere in our scripts. If we are using
   PULSAR_ for appending new keys, then we are potentially appending
   a wrong key into the config file.
   
   Currently this happens on presto. We are appending PULSAR_ROOT_LOGGER
   into presto's config file and cause presto fail to load the config.
   
   Modifications
   
   Use INSERTPULSARKEY_ instead of PULSAR_
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services