[GitHub] [syncope] mmoayyed commented on a change in pull request #273: Switch to CAS 6.4 RC5

[GitBox <gi...@apache.org>]

mmoayyed commented on a change in pull request #273:
URL: https://github.com/apache/syncope/pull/273#discussion_r650696389



##########
File path: pom.xml
##########
@@ -2045,40 +2005,6 @@ under the License.
         <enabled>true</enabled>
       </releases>
     </repository>
-
-    <!-- Disable some Spring repositories pulled in by dependencies - see

Review comment:
       Why would you want to keep disabled repositories? 

##########
File path: pom.xml
##########
@@ -2045,40 +2005,6 @@ under the License.
         <enabled>true</enabled>
       </releases>
     </repository>
-
-    <!-- Disable some Spring repositories pulled in by dependencies - see

Review comment:
       It is, but disabling a repository is effectively the same as a no-op. It's dead code, and certainly, the repositories are no longer needed and have been removed from upstream references. If you're telling maven, "don't use this repository for anything", then it would make sense to remove "unused" code.

##########
File path: pom.xml
##########
@@ -2045,40 +2005,6 @@ under the License.
         <enabled>true</enabled>
       </releases>
     </repository>
-
-    <!-- Disable some Spring repositories pulled in by dependencies - see

Review comment:
       Could you point out what those dependencies are? Can we upgrade those? And I don't follow. If the repository is 100% disabled, how are those dependencies resolved? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org