[GitHub] [arrow-datafusion] alamb commented on pull request #6619: Minor: Move get_equal_orderings into `BuiltInWindowFunctionExpr`, remove `BuiltInWindowFunctionExpr::as_any`

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on PR #6619:
URL: https://github.com/apache/arrow-datafusion/pull/6619#issuecomment-1587309700

   > By the way regarding the as_any() as fas as I can remember it is not introduces by us. I am not familiar with its purpose. However, even though we no longer have special handling outside and no use-case for it in datafusion code base. I can imagine it may be useful for others. I wonder what others think about it.
   
   @Jimexist  (who I think added the first version of window functions and perhaps the trait), @andygrove,  @viirya  or @Dandandan  do you have any thoughts about keeping / removing the `as_any`, or leaving it in?
   
   Given the question, I think the safe thing will be to change this PR to put back the `as_any` and we can then discuss that change separately. I'll plan to restore `as_any` in this PR if I don't hear any other comments


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org