[jira] [Updated] (MAPREDUCE-6824) TaskAttemptImpl#createCommonContainerLaunchContext is longer than 150 lines

["Chris Trezzo (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAPREDUCE-6824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Trezzo updated MAPREDUCE-6824:
------------------------------------
    Attachment: MAPREDUCE-6824-trunk.001.patch

Attached is a v1 patch for trunk. I have split the following out into separate methods:
# Job jar configuration.
# Job conf configuration.
# Token setup.
# External shuffle provider setup.

I did not modify any unit tests because this is a straightforward refactor. Existing coverage should handle this change.

> TaskAttemptImpl#createCommonContainerLaunchContext is longer than 150 lines
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6824
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6824
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>            Priority: Trivial
>              Labels: newbie
>         Attachments: MAPREDUCE-6824-trunk.001.patch
>
>
> bq. ./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java:752: private static ContainerLaunchContext createCommonContainerLaunchContext(:3: Method length is 172 lines (max allowed is 150).
> {{TaskAttemptImpl#createCommonContainerLaunchContext}} is longer than 150 lines and needs to be refactored.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org