You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/12/06 16:33:16 UTC

Review Request 64385: Used more restrictive mount flags for host network bind mounts.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64385/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jiang Yan Xu.


Bugs: MESOS-8286
    https://issues.apache.org/jira/browse/MESOS-8286


Repository: mesos


Description
-------

In the CNI isolator, mount the network configuration files with
the most restrictive mount flags to avoid getting trapped by user
namespace unprivileged mount preconditions.


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 0eca067c133004ae95e61ca9280cbaebed0f8357 


Diff: https://reviews.apache.org/r/64385/diff/1/


Testing
-------

sudo make check (Fedora 27)


Thanks,

James Peach


Re: Review Request 64385: Used more restrictive mount flags for host network bind mounts.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64385/#review193054
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 6, 2017, 4:33 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64385/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2017, 4:33 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8286
>     https://issues.apache.org/jira/browse/MESOS-8286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In the CNI isolator, mount the network configuration files with
> the most restrictive mount flags to avoid getting trapped by user
> namespace unprivileged mount preconditions.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 0eca067c133004ae95e61ca9280cbaebed0f8357 
> 
> 
> Diff: https://reviews.apache.org/r/64385/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>