You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/04/29 10:26:00 UTC

[jira] [Commented] (HBASE-24249) Move code in FSHDFSUtils to FSUtils and mark related classes as final

    [ https://issues.apache.org/jira/browse/HBASE-24249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095320#comment-17095320 ] 

Hudson commented on HBASE-24249:
--------------------------------

Results for branch branch-2
	[build #2634 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2634/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2634/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2634/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2634/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2634/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move code in FSHDFSUtils to FSUtils and mark related classes as final
> ---------------------------------------------------------------------
>
>                 Key: HBASE-24249
>                 URL: https://issues.apache.org/jira/browse/HBASE-24249
>             Project: HBase
>          Issue Type: Task
>          Components: Filesystem Integration
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0, 2.3.0
>
>
> It is a bit strange that a 'util' class can be instantiated.
> I think the motivation is to provide multiple recoverFileLease implementation based on different filesystem implementation. But until now, there is still only one implementation for HDFS in HBase, and all the related classes are marked as IA.Private so we do not expect user to extend the class.
> Let's just move the code in FSHDFSUtils to FSUtils directly and make FSUtils a true 'util' class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)