[GitHub] [hudi] danny0405 commented on a diff in pull request #8080: [HUDI-5865] Fix table service client to instantiate with timeline server

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8080:
URL: https://github.com/apache/hudi/pull/8080#discussion_r1121455483


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -87,8 +88,10 @@
 
   protected Set<String> pendingInflightAndRequestedInstants;
 
-  protected BaseHoodieTableServiceClient(HoodieEngineContext context, HoodieWriteConfig clientConfig) {
-    super(context, clientConfig, Option.empty());
+  protected BaseHoodieTableServiceClient(HoodieEngineContext context,
+                                         HoodieWriteConfig clientConfig,
+                                         Option<EmbeddedTimelineService> timelineService) {

Review Comment:
   I don't know what to say, but I'm scared and shocked by this kind of ticky bug, let's add some tests for the table service client.
   
   Ahother bug introduced by code rafactoring.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org