You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org> on 2025/02/12 14:33:19 UTC
[PR] apps/bttester: Fixes [mynewt-nimble]
andrzej-kaczmarek opened a new pull request, #1975:
URL: https://github.com/apache/mynewt-nimble/pull/1975
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] apps/bttester: Fixes [mynewt-nimble]
Posted by "KKopyscinski (via GitHub)" <gi...@apache.org>.
KKopyscinski commented on code in PR #1975:
URL: https://github.com/apache/mynewt-nimble/pull/1975#discussion_r1952797045
##########
apps/bttester/src/btp_l2cap.c:
##########
@@ -748,6 +749,8 @@ tester_init_l2cap(void)
tester_register_command_handlers(BTP_SERVICE_ID_L2CAP, handlers,
ARRAY_SIZE(handlers));
+#endif
Review Comment:
I wonder if proper way to do this would be register commands, but do not compile any command besides `BTP_L2CAP_READ_SUPPORTED_COMMANDS`, and in `supported_commands()` set only
```c
tester_set_bit(rp->data, BTP_L2CAP_READ_SUPPORTED_COMMANDS);
```
and rest put under `#if MYNEWT_VAL(BLE_L2CAP_COC_MAX_NUM)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] apps/bttester: Fixes [mynewt-nimble]
Posted by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org>.
andrzej-kaczmarek merged PR #1975:
URL: https://github.com/apache/mynewt-nimble/pull/1975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org