You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ti...@apache.org on 2020/03/25 18:08:16 UTC

[cordova-plugin-inappbrowser] branch master updated: fix(android): Reset lefttoright if not set (#442)

This is an automated email from the ASF dual-hosted git repository.

timbru31 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git


The following commit(s) were added to refs/heads/master by this push:
     new 290841d  fix(android): Reset lefttoright if not set (#442)
290841d is described below

commit 290841dea6a2942827cff2bb512118e3908cdd8e
Author: Jesse MacFadyen <pu...@gmail.com>
AuthorDate: Wed Mar 25 11:08:04 2020 -0700

    fix(android): Reset lefttoright if not set (#442)
    
    This fixes #441
---
 src/android/InAppBrowser.java | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index e2c16f9..f5236ff 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -694,9 +694,8 @@ public class InAppBrowser extends CordovaPlugin {
                 closeButtonColor = closeButtonColorSet;
             }
             String leftToRightSet = features.get(LEFT_TO_RIGHT);
-            if (leftToRightSet != null) {
-                leftToRight = leftToRightSet.equals("yes") ? true : false;
-            }
+            leftToRight = leftToRightSet != null && leftToRightSet.equals("yes");
+
             String toolbarColorSet = features.get(TOOLBAR_COLOR);
             if (toolbarColorSet != null) {
                 toolbarColor = android.graphics.Color.parseColor(toolbarColorSet);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org