[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6621: Add mark and count methods in PinotMeter interface

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #6621:
URL: https://github.com/apache/incubator-pinot/pull/6621#discussion_r584222300



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/metrics/PinotMeter.java
##########
@@ -26,5 +26,9 @@
  */
 public interface PinotMeter {
 
+  void mark();

Review comment:
       Can you add some javadoc?
   I think mark() adds 1, and mark(value) adds value. And count() returns the value, it seems.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org