You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/02/01 06:51:34 UTC
[GitHub] [spark] itholic opened a new pull request, #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
itholic opened a new pull request, #39839:
URL: https://github.com/apache/spark/pull/39839
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR proposes to assign name to _LEGACY_ERROR_TEMP_2430, "INCOMPATIBLE_COLUMN_TYPE".
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We should assign proper name to _LEGACY_ERROR_TEMP_*
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
`./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
URL: https://github.com/apache/spark/pull/39839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #39839:
URL: https://github.com/apache/spark/pull/39839#discussion_r1095675824
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala:
##########
@@ -955,30 +955,65 @@ class AnalysisSuite extends AnalysisTest with Matchers {
val r4 = Except(firstTable, secondTable, isAll = false)
val r5 = Intersect(firstTable, secondTable, isAll = false)
- assertAnalysisError(r1,
- Seq("Union can only be performed on tables with compatible column types. " +
- "The second column of the second table is timestamp type which is not compatible " +
- "with double at the same column of the first table"))
-
- assertAnalysisError(r2,
- Seq("Union can only be performed on tables with compatible column types. " +
- "The third column of the second table is timestamp type which is not compatible " +
- "with int at the same column of the first table"))
-
- assertAnalysisError(r3,
- Seq("Union can only be performed on tables with compatible column types. " +
- "The 4th column of the second table is timestamp type which is not compatible " +
- "with float at the same column of the first table"))
-
- assertAnalysisError(r4,
- Seq("Except can only be performed on tables with compatible column types. " +
- "The second column of the second table is timestamp type which is not compatible " +
- "with double at the same column of the first table"))
-
- assertAnalysisError(r5,
- Seq("Intersect can only be performed on tables with compatible column types. " +
- "The second column of the second table is timestamp type which is not compatible " +
- "with double at the same column of the first table"))
+ assertAnalysisErrorClass(
+ r1,
Review Comment:
nit: just inline `r1` since it is used only once. (the same for r2..r5).
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -570,13 +570,13 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
// SPARK-18058: we shall not care about the nullability of columns
if (!dataTypesAreCompatibleFn(dt1, dt2)) {
e.failAnalysis(
- errorClass = "_LEGACY_ERROR_TEMP_2430",
+ errorClass = "INCOMPATIBLE_COLUMN_TYPE",
messageParameters = Map(
"operator" -> toSQLStmt(operator.nodeName),
- "ci" -> ordinalNumber(ci),
- "ti" -> ordinalNumber(ti + 1),
- "dt1" -> dt1.catalogString,
- "dt2" -> dt2.catalogString,
+ "columnOrdinalNumber" -> ordinalNumber(ci),
+ "tableOrdinalNumber" -> ordinalNumber(ti + 1),
+ "dataType1" -> toSQLType(dt1.catalogString),
+ "dataType2" -> toSQLType(dt2.catalogString),
Review Comment:
Please, don't form the type strings yourself via `catalogString()`. Use `toSQLType()` which invokes `sql()`:
```suggestion
"dataType1" -> toSQLType(dt1),
"dataType2" -> toSQLType(dt2),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39839:
URL: https://github.com/apache/spark/pull/39839#discussion_r1095852149
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -570,13 +570,13 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
// SPARK-18058: we shall not care about the nullability of columns
if (!dataTypesAreCompatibleFn(dt1, dt2)) {
e.failAnalysis(
- errorClass = "_LEGACY_ERROR_TEMP_2430",
+ errorClass = "INCOMPATIBLE_COLUMN_TYPE",
messageParameters = Map(
"operator" -> toSQLStmt(operator.nodeName),
- "ci" -> ordinalNumber(ci),
- "ti" -> ordinalNumber(ti + 1),
- "dt1" -> dt1.catalogString,
- "dt2" -> dt2.catalogString,
+ "columnOrdinalNumber" -> ordinalNumber(ci),
+ "tableOrdinalNumber" -> ordinalNumber(ti + 1),
+ "dataType1" -> toSQLType(dt1.catalogString),
+ "dataType2" -> toSQLType(dt2.catalogString),
Review Comment:
Updated, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #39839:
URL: https://github.com/apache/spark/pull/39839#discussion_r1092840158
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -581,6 +581,11 @@
],
"sqlState" : "42818"
},
+ "INCOMPATIBLE_COLUMN_TYPE" : {
+ "message" : [
+ "<operator> can only be performed on tables with compatible column types. The <ci> column of the <ti> table is <dt1> type which is not compatible with <dt2> at the same column of the first table.<hint>."
Review Comment:
shall we rename parameters? `ci` and `ti` looks confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39839:
URL: https://github.com/apache/spark/pull/39839#discussion_r1095852449
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala:
##########
@@ -955,30 +955,65 @@ class AnalysisSuite extends AnalysisTest with Matchers {
val r4 = Except(firstTable, secondTable, isAll = false)
val r5 = Intersect(firstTable, secondTable, isAll = false)
- assertAnalysisError(r1,
- Seq("Union can only be performed on tables with compatible column types. " +
- "The second column of the second table is timestamp type which is not compatible " +
- "with double at the same column of the first table"))
-
- assertAnalysisError(r2,
- Seq("Union can only be performed on tables with compatible column types. " +
- "The third column of the second table is timestamp type which is not compatible " +
- "with int at the same column of the first table"))
-
- assertAnalysisError(r3,
- Seq("Union can only be performed on tables with compatible column types. " +
- "The 4th column of the second table is timestamp type which is not compatible " +
- "with float at the same column of the first table"))
-
- assertAnalysisError(r4,
- Seq("Except can only be performed on tables with compatible column types. " +
- "The second column of the second table is timestamp type which is not compatible " +
- "with double at the same column of the first table"))
-
- assertAnalysisError(r5,
- Seq("Intersect can only be performed on tables with compatible column types. " +
- "The second column of the second table is timestamp type which is not compatible " +
- "with double at the same column of the first table"))
+ assertAnalysisErrorClass(
+ r1,
Review Comment:
Sounds good. Just updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #39839:
URL: https://github.com/apache/spark/pull/39839#issuecomment-1419294774
+1, LGTM. Merging to master/3.4.
Thank you, @itholic and @cloud-fan @srielau for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #39839:
URL: https://github.com/apache/spark/pull/39839#discussion_r1093316785
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -581,6 +581,11 @@
],
"sqlState" : "42818"
},
+ "INCOMPATIBLE_COLUMN_TYPE" : {
+ "message" : [
+ "<operator> can only be performed on tables with compatible column types. The <columnOrdinalNumber> column of the <tableOrdinalNumber> table is <dataType1> type which is not compatible with <dataType2> at the same column of the first table.<hint>."
+ ]
Review Comment:
```suggestion
],
"sqlState" : "42825"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #39839:
URL: https://github.com/apache/spark/pull/39839#issuecomment-1411548830
cc @MaxGekk @srielau @cloud-fan PTAL error class review ticket when you find some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39839:
URL: https://github.com/apache/spark/pull/39839#discussion_r1092850557
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -581,6 +581,11 @@
],
"sqlState" : "42818"
},
+ "INCOMPATIBLE_COLUMN_TYPE" : {
+ "message" : [
+ "<operator> can only be performed on tables with compatible column types. The <ci> column of the <ti> table is <dt1> type which is not compatible with <dt2> at the same column of the first table.<hint>."
Review Comment:
Sounds good! Let me update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39839:
URL: https://github.com/apache/spark/pull/39839#discussion_r1093373279
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -581,6 +581,11 @@
],
"sqlState" : "42818"
},
+ "INCOMPATIBLE_COLUMN_TYPE" : {
+ "message" : [
+ "<operator> can only be performed on tables with compatible column types. The <columnOrdinalNumber> column of the <tableOrdinalNumber> table is <dataType1> type which is not compatible with <dataType2> at the same column of the first table.<hint>."
+ ]
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39839: [SPARK-42255][SQL] Assign name to _LEGACY_ERROR_TEMP_2430
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39839:
URL: https://github.com/apache/spark/pull/39839#discussion_r1093292933
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -581,6 +581,11 @@
],
"sqlState" : "42818"
},
+ "INCOMPATIBLE_COLUMN_TYPE" : {
+ "message" : [
+ "<operator> can only be performed on tables with compatible column types. The <ci> column of the <ti> table is <dt1> type which is not compatible with <dt2> at the same column of the first table.<hint>."
Review Comment:
Updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org