[GitHub] [airflow] jhtimmins commented on a change in pull request #8598: make hive macros py3 compatible with decoded string return type

[GitBox <gi...@apache.org>]

jhtimmins commented on a change in pull request #8598:
URL: https://github.com/apache/airflow/pull/8598#discussion_r416811013



##########
File path: airflow/providers/apache/hive/hooks/hive.py
##########
@@ -708,7 +708,11 @@ def _get_max_partition_from_part_specs(part_specs, partition_key, filter_map):
         if not candidates:
             return None
         else:
-            return max(candidates).encode('utf-8')
+            max_val = max(candidates).encode('utf-8')
+            # check is for python3 to keep same behavior or returning a string type

Review comment:
       Should this say `of` instead of `or`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org