You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/05/11 13:07:12 UTC
Review Request 59175: Ambari infra manager: add batch support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59175/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-20989
https://issues.apache.org/jira/browse/AMBARI-20989
Repository: ambari
Description
-------
Add basic spring batch support with a dummy item writer/reader/processor.
Also add some rest entripoint to run and gather jobs/execution ids.
Using sqlite as database -> the whole database is inside in one local file. Later it can be more configurable.
Diffs
-----
ambari-infra/.gitignore PRE-CREATION
ambari-infra/ambari-infra-manager/pom.xml c3a09ab
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemProcessor.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyObject.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 45b1ca5
ambari-infra/ambari-infra-manager/src/main/resources/dummy/dummy.csv PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 13878a1
Diff: https://reviews.apache.org/r/59175/diff/1/
Testing
-------
tested manually.
Thanks,
Oliver Szabo
Re: Review Request 59175: Ambari infra manager: add batch support
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59175/
-----------------------------------------------------------
(Updated May 12, 2017, 9:16 a.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
fix typo
Bugs: AMBARI-20989
https://issues.apache.org/jira/browse/AMBARI-20989
Repository: ambari
Description
-------
Add basic spring batch support with a dummy item writer/reader/processor.
Also add some rest entripoint to run and gather jobs/execution ids.
Using sqlite as database -> the whole database is inside in one local file. Later it can be more configurable.
Added schedule support as well see @EnableScheduling
Diffs (updated)
-----
ambari-infra/.gitignore PRE-CREATION
ambari-infra/ambari-infra-manager/pom.xml c3a09ab
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemProcessor.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyObject.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 45b1ca5
ambari-infra/ambari-infra-manager/src/main/resources/dummy/dummy.csv PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 13878a1
Diff: https://reviews.apache.org/r/59175/diff/2/
Changes: https://reviews.apache.org/r/59175/diff/1-2/
Testing
-------
tested manually.
Thanks,
Oliver Szabo
Re: Review Request 59175: Ambari infra manager: add batch support
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59175/#review174770
-----------------------------------------------------------
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
Lines 73 (patched)
<https://reviews.apache.org/r/59175/#comment248005>
Reopsitory --> Repository
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
Lines 76 (patched)
<https://reviews.apache.org/r/59175/#comment248006>
Reopsitory --> Repository
- Miklos Gergely
On May 11, 2017, 1:30 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59175/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 1:30 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-20989
> https://issues.apache.org/jira/browse/AMBARI-20989
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add basic spring batch support with a dummy item writer/reader/processor.
> Also add some rest entripoint to run and gather jobs/execution ids.
> Using sqlite as database -> the whole database is inside in one local file. Later it can be more configurable.
>
> Added schedule support as well see @EnableScheduling
>
>
> Diffs
> -----
>
> ambari-infra/.gitignore PRE-CREATION
> ambari-infra/ambari-infra-manager/pom.xml c3a09ab
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemProcessor.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyObject.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 45b1ca5
> ambari-infra/ambari-infra-manager/src/main/resources/dummy/dummy.csv PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 13878a1
>
>
> Diff: https://reviews.apache.org/r/59175/diff/1/
>
>
> Testing
> -------
>
> tested manually.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 59175: Ambari infra manager: add batch support
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59175/#review174771
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On May 11, 2017, 1:30 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59175/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 1:30 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-20989
> https://issues.apache.org/jira/browse/AMBARI-20989
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add basic spring batch support with a dummy item writer/reader/processor.
> Also add some rest entripoint to run and gather jobs/execution ids.
> Using sqlite as database -> the whole database is inside in one local file. Later it can be more configurable.
>
> Added schedule support as well see @EnableScheduling
>
>
> Diffs
> -----
>
> ambari-infra/.gitignore PRE-CREATION
> ambari-infra/ambari-infra-manager/pom.xml c3a09ab
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemProcessor.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyObject.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 45b1ca5
> ambari-infra/ambari-infra-manager/src/main/resources/dummy/dummy.csv PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 13878a1
>
>
> Diff: https://reviews.apache.org/r/59175/diff/1/
>
>
> Testing
> -------
>
> tested manually.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 59175: Ambari infra manager: add batch support
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59175/#review174716
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On May 11, 2017, 1:30 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59175/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 1:30 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-20989
> https://issues.apache.org/jira/browse/AMBARI-20989
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add basic spring batch support with a dummy item writer/reader/processor.
> Also add some rest entripoint to run and gather jobs/execution ids.
> Using sqlite as database -> the whole database is inside in one local file. Later it can be more configurable.
>
> Added schedule support as well see @EnableScheduling
>
>
> Diffs
> -----
>
> ambari-infra/.gitignore PRE-CREATION
> ambari-infra/ambari-infra-manager/pom.xml c3a09ab
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemProcessor.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyObject.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 45b1ca5
> ambari-infra/ambari-infra-manager/src/main/resources/dummy/dummy.csv PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 13878a1
>
>
> Diff: https://reviews.apache.org/r/59175/diff/1/
>
>
> Testing
> -------
>
> tested manually.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 59175: Ambari infra manager: add batch support
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59175/
-----------------------------------------------------------
(Updated May 11, 2017, 1:30 p.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
add scheduling support
Bugs: AMBARI-20989
https://issues.apache.org/jira/browse/AMBARI-20989
Repository: ambari
Description (updated)
-------
Add basic spring batch support with a dummy item writer/reader/processor.
Also add some rest entripoint to run and gather jobs/execution ids.
Using sqlite as database -> the whole database is inside in one local file. Later it can be more configurable.
Added schedule support as well see @EnableScheduling
Diffs
-----
ambari-infra/.gitignore PRE-CREATION
ambari-infra/ambari-infra-manager/pom.xml c3a09ab
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemProcessor.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyObject.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java 45b1ca5
ambari-infra/ambari-infra-manager/src/main/resources/dummy/dummy.csv PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 13878a1
Diff: https://reviews.apache.org/r/59175/diff/1/
Testing
-------
tested manually.
Thanks,
Oliver Szabo