You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/03/14 09:38:47 UTC
[GitHub] [sling-org-apache-sling-commons-threads] rombert opened a new pull request #4: SLING-11161 Support testing with different JDKs
rombert opened a new pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-commons-threads/pull/4
Also build with JDK 8 in Jenkins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-threads] oliverlietz commented on a change in pull request #4: SLING-11161 Support testing with different JDKs
Posted by GitBox <gi...@apache.org>.
oliverlietz commented on a change in pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-commons-threads/pull/4#discussion_r825768169
##########
File path: .sling-module.json
##########
@@ -2,7 +2,8 @@
"jenkins": {
"jdks": [
17,
- 11
+ 11,
+ 8
Review comment:
Compiling with 8 will not work, for JPMS you need at least 9. The whole purpose of SLING-11161 is to build with JDK > 8 for target 8 and test on LTS versions 8, 11 and 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-threads] rombert commented on a change in pull request #4: SLING-11161 Support testing with different JDKs
Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-commons-threads/pull/4#discussion_r825772798
##########
File path: .sling-module.json
##########
@@ -2,7 +2,8 @@
"jenkins": {
"jdks": [
17,
- 11
+ 11,
+ 8
Review comment:
Thanks for the clarification @oliverlietz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-threads] rombert closed pull request #4: SLING-11161 Support testing with different JDKs
Posted by GitBox <gi...@apache.org>.
rombert closed pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-commons-threads/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org