You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2014/09/24 10:08:39 UTC
svn commit: r1627249 - /subversion/branches/move-tracking-2/configure.ac
Author: julianfoad
Date: Wed Sep 24 08:08:39 2014
New Revision: 1627249
URL: http://svn.apache.org/r1627249
Log:
On the 'move-tracking-2' branch: Don't warn about functions returning an
aggregate (structure) value, as it's convenient to do so on this branch.
* configure.ac
(CMAINTAINERFLAGS): Remove '-Waggregate-return'.
Modified:
subversion/branches/move-tracking-2/configure.ac
Modified: subversion/branches/move-tracking-2/configure.ac
URL: http://svn.apache.org/viewvc/subversion/branches/move-tracking-2/configure.ac?rev=1627249&r1=1627248&r2=1627249&view=diff
==============================================================================
--- subversion/branches/move-tracking-2/configure.ac (original)
+++ subversion/branches/move-tracking-2/configure.ac Wed Sep 24 08:08:39 2014
@@ -1066,7 +1066,7 @@ AS_HELP_STRING([--enable-maintainer-mode
CFLAGS="$CFLAGS_KEEP"
dnl Add flags that all versions of GCC (should) support
- CMAINTAINERFLAGS="-Wall -Wpointer-arith -Wwrite-strings -Wshadow -Wformat=2 -Wunused -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wno-multichar -Wredundant-decls -Wnested-externs -Winline -Wno-long-long -Wbad-function-cast $CMAINTAINERFLAGS"
+ CMAINTAINERFLAGS="-Wall -Wpointer-arith -Wwrite-strings -Wshadow -Wformat=2 -Wunused -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wno-multichar -Wredundant-decls -Wnested-externs -Winline -Wno-long-long -Wbad-function-cast $CMAINTAINERFLAGS"
fi
if test "$GXX" = "yes"; then
AC_MSG_NOTICE([maintainer-mode: adding G++ warning flags])
Re: svn commit: r1627249 - /subversion/branches/move-tracking-2/configure.ac
Posted by Branko Čibej <br...@wandisco.com>.
On 24.09.2014 10:08, julianfoad@apache.org wrote:
> Author: julianfoad
> Date: Wed Sep 24 08:08:39 2014
> New Revision: 1627249
>
> URL: http://svn.apache.org/r1627249
> Log:
> On the 'move-tracking-2' branch: Don't warn about functions returning an
> aggregate (structure) value, as it's convenient to do so on this branch.
I guess we could remove this warning everywhere, since there are
probably no ancient K&R compilers out there any more. OTOH, you should
be aware that returning structs (as opposed to initializing a struct by
reference on the caller's stack) often generates an extra memcopy in C.
-- Brane