You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "xianjingfeng (via GitHub)" <gi...@apache.org> on 2023/04/13 02:07:13 UTC
[GitHub] [incubator-uniffle] xianjingfeng opened a new pull request, #821: [#796] bug:fix the issues of MetricReporter(for 0.7)
xianjingfeng opened a new pull request, #821:
URL: https://github.com/apache/incubator-uniffle/pull/821
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
1. Support custom config keys defined in plugins
2. Refactor the logic for load config file
3. Fix some issues of metricReporter.
### Why are the changes needed?
Metric reporter is unusable.
Fix: #796
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
UT and Manual testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #821: [#796][0.7] bug:fix the issues of MetricReporter
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #821:
URL: https://github.com/apache/incubator-uniffle/pull/821#issuecomment-1506427611
It is ok now, just reopen it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #821: [#796][0.7] bug:fix the issues of MetricReporter
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #821:
URL: https://github.com/apache/incubator-uniffle/pull/821#issuecomment-1506236171
It seems that this PR is merged to master in CI enviroment. But the first time is ok.
https://github.com/apache/incubator-uniffle/actions/runs/4684746312/jobs/8301194063
Do you know why? @kaijchen @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #821: [#796][0.7] bug:fix the issues of MetricReporter
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #821:
URL: https://github.com/apache/incubator-uniffle/pull/821#issuecomment-1506244521
> > You could rerun your pr.
>
> Please rebase or merge branch-0.7.
<img width="699" alt="企业微信截图_90010f5d-d8b3-4afd-9ad7-45b8ba63e889" src="https://user-images.githubusercontent.com/8159038/231632919-8d79b43f-6c30-44b6-86ab-6bb8a9db5f17.png">
But his commit history don't have my mistake commit. It's strange. But the error seems that it caused by my mistake commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #821: [#796][0.7] bug:fix the issues of MetricReporter
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #821:
URL: https://github.com/apache/incubator-uniffle/pull/821#issuecomment-1506237971
> It seems that this PR is merged to master in CI enviroment. But the first time is ok. https://github.com/apache/incubator-uniffle/actions/runs/4684746312/jobs/8301194063
>
> Do you know why? @kaijchen @jerqi
I cherry-pick a wrong commit. I have reverted it. it's strange that it influence your pr. You could rerun your pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #821: [#796][0.7] bug:fix the issues of MetricReporter
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #821:
URL: https://github.com/apache/incubator-uniffle/pull/821#issuecomment-1506229071
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/821?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#821](https://codecov.io/gh/apache/incubator-uniffle/pull/821?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0507c87) into [branch-0.7](https://codecov.io/gh/apache/incubator-uniffle/commit/6857ea51c614a149ae9f3a92876dc15c315f5dfb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6857ea5) will **increase** coverage by `1.01%`.
> The diff coverage is `47.36%`.
> :exclamation: Current head 0507c87 differs from pull request most recent head e49f83a. Consider uploading reports for the commit e49f83a to get more accurate results
```diff
@@ Coverage Diff @@
## branch-0.7 #821 +/- ##
================================================
+ Coverage 60.89% 61.91% +1.01%
+ Complexity 1800 1698 -102
================================================
Files 214 191 -23
Lines 12386 9847 -2539
Branches 1042 1001 -41
================================================
- Hits 7543 6097 -1446
+ Misses 4440 3422 -1018
+ Partials 403 328 -75
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/uniffle/common/config/RssConf.java](https://codecov.io/gh/apache/incubator-uniffle/pull/821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9jb25maWcvUnNzQ29uZi5qYXZh) | `29.93% <0.00%> (-2.48%)` | :arrow_down: |
| [...rometheus/PrometheusPushGatewayMetricReporter.java](https://codecov.io/gh/apache/incubator-uniffle/pull/821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9tZXRyaWNzL3Byb21ldGhldXMvUHJvbWV0aGV1c1B1c2hHYXRld2F5TWV0cmljUmVwb3J0ZXIuamF2YQ==) | `74.46% <0.00%> (ø)` | |
| [.../apache/uniffle/coordinator/CoordinatorServer.java](https://codecov.io/gh/apache/incubator-uniffle/pull/821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQ29vcmRpbmF0b3JTZXJ2ZXIuamF2YQ==) | `56.45% <0.00%> (-0.93%)` | :arrow_down: |
| [.../java/org/apache/uniffle/server/ShuffleServer.java](https://codecov.io/gh/apache/incubator-uniffle/pull/821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyLmphdmE=) | `60.54% <0.00%> (-3.84%)` | :arrow_down: |
| [.../org/apache/uniffle/common/config/RssBaseConf.java](https://codecov.io/gh/apache/incubator-uniffle/pull/821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9jb25maWcvUnNzQmFzZUNvbmYuamF2YQ==) | `96.64% <78.94%> (+2.60%)` | :arrow_up: |
| [.../uniffle/common/metrics/MetricReporterFactory.java](https://codecov.io/gh/apache/incubator-uniffle/pull/821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9tZXRyaWNzL01ldHJpY1JlcG9ydGVyRmFjdG9yeS5qYXZh) | `57.14% <100.00%> (ø)` | |
| [...rg/apache/uniffle/coordinator/CoordinatorConf.java](https://codecov.io/gh/apache/incubator-uniffle/pull/821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQ29vcmRpbmF0b3JDb25mLmphdmE=) | `98.70% <100.00%> (+1.11%)` | :arrow_up: |
| [...a/org/apache/uniffle/server/ShuffleServerConf.java](https://codecov.io/gh/apache/incubator-uniffle/pull/821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyQ29uZi5qYXZh) | `99.28% <100.00%> (-0.04%)` | :arrow_down: |
... and [23 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/821/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #821: [#796][0.7] bug:fix the issues of MetricReporter
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #821:
URL: https://github.com/apache/incubator-uniffle/pull/821#issuecomment-1506240417
> You could rerun your pr.
Please rebase or merge branch-0.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng closed pull request #821: [#796][0.7] bug:fix the issues of MetricReporter
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng closed pull request #821: [#796][0.7] bug:fix the issues of MetricReporter
URL: https://github.com/apache/incubator-uniffle/pull/821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng merged pull request #821: [#796][0.7] bug: Fix the issues of MetricReporter
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng merged PR #821:
URL: https://github.com/apache/incubator-uniffle/pull/821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org