You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/13 09:49:31 UTC
[GitHub] [doris] Henry2SS opened a new pull request, #10812: [Enhancement](dynamic partition) dynamic partition addPartition should be allowed when distributionCol…
Henry2SS opened a new pull request, #10812:
URL: https://github.com/apache/doris/pull/10812
…umns' comments had been changed
# Proposed changes
Issue Number: close #10811
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #10812: [Enhancement](dynamic partition) dynamic partition addPartition should be allowed when distributionCol…
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #10812:
URL: https://github.com/apache/doris/pull/10812#discussion_r919881933
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalDataSource.java:
##########
@@ -1258,11 +1258,24 @@ public void addPartition(Database db, String tableName, AddPartitionClause addPa
List<Column> newDistriCols = hashDistributionInfo.getDistributionColumns();
List<Column> defaultDistriCols =
((HashDistributionInfo) defaultDistributionInfo).getDistributionColumns();
- if (!newDistriCols.equals(defaultDistriCols)) {
+ if (newDistriCols.size() != defaultDistriCols.size()) {
throw new DdlException(
"Cannot assign hash distribution with different distribution cols. " + "default is: "
+ defaultDistriCols);
+ } else {
+ for (int i = 0; i < defaultDistriCols.size(); i++) {
Review Comment:
Please add comment to explain why we only check name and type.
And I think name can also be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] closed pull request #10812: [Enhancement](dynamic partition) dynamic partition addPartition should be allowed when distributionCol…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #10812: [Enhancement](dynamic partition) dynamic partition addPartition should be allowed when distributionCol…
URL: https://github.com/apache/doris/pull/10812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10812: [Enhancement](dynamic partition) dynamic partition addPartition should be allowed when distributionCol…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10812:
URL: https://github.com/apache/doris/pull/10812#issuecomment-1379641142
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org