You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Robert Munteanu <ro...@apache.org> on 2020/06/18 11:37:10 UTC

[VOTE] Release Apache Sling Dynamic Include 3.2.0

Hi,

We solved 5 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12346080

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2283/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2283 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

Re: [VOTE] Release Apache Sling Dynamic Include 3.2.0

Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2020-06-22 at 13:39 +0200, Bertrand Delacretaz wrote:
> Hi,
> 
> On Mon, Jun 22, 2020 at 1:26 PM Robert Munteanu <ro...@apache.org>
> wrote:
> > ...I see three ways of advancing:
> > 
> > - saying this is not a problem and continuing with the release ..
> 
> If someone needs this release soon, I'm fine. I have explained the
> problem and workaround at SLING-8987#
> 
> > - redoing the release as 3.2.2 add silencing baselining for this
> > release only..
> 
> I don't think that's needed
> 
> > - redoing the release as 4.0.0
> 
> That would be nice but the build workaround is good enough if someone
> is waiting on 3.2.0

Ack, thanks Bertrand. I will go on with the release as 3.2.0.

Thanks,
Robert


Re: [VOTE] Release Apache Sling Dynamic Include 3.2.0

Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,

On Mon, Jun 22, 2020 at 1:26 PM Robert Munteanu <ro...@apache.org> wrote:
> ...I see three ways of advancing:
>
> - saying this is not a problem and continuing with the release ..

If someone needs this release soon, I'm fine. I have explained the
problem and workaround at SLING-8987#

> - redoing the release as 3.2.2 add silencing baselining for this release only..

I don't think that's needed

> - redoing the release as 4.0.0

That would be nice but the build workaround is good enough if someone
is waiting on 3.2.0

-Bertrand

Re: [VOTE] Release Apache Sling Dynamic Include 3.2.0

Posted by Robert Munteanu <ro...@apache.org>.
Hi Bertrand,

On Mon, 2020-06-22 at 12:40 +0200, Bertrand Delacretaz wrote:
> On Thu, Jun 18, 2020 at 1:37 PM Robert Munteanu <ro...@apache.org>
> wrote:
> > ...Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2283/
> > ..
> 
> I'm getting an error from the maven baseline plugin when trying to
> build this from
> org.apache.sling.dynamic-include-3.2.0-source-release.zip
> 
> [WARNING] Could not transfer metadata
> org.apache.sling:org.apache.sling.dynamic-include/maven-metadata.xml
> from/to apache.releases.https
> (https://repository.apache.org/service/local/staging/deploy/maven2):
> Failed to transfer file
> https://repository.apache.org/service/local/staging/deploy/maven2/org/apache/sling/org.apache.sling.dynamic-include/maven-metadata.xml
> with status code 400
> [INFO] The baseline version was found to be 3.1.6
> [ERROR] The bundle version change (3.1.6 to 3.2.0) is too low, the
> new
> version must be at least 4.0.0

> Am I doing something wrong?

You're not doing anything wrong. This is due to 

  https://issues.apache.org/jira/browse/SLING-8987

where I removed the exported packages. Technically, the bundle version
should be 4.0.0 . On the other hand, I asked around and could not find
anyone actually importing the packages, so I considered that this could
be treated as a minor version bump and not as a breaking change.

The problem now is, indeed, that the source archive does not build out-
of-the-box, and you would need to add -Dbnd.baseline.skip to the build
arguments.

I see three ways of advancing:

- saying this is not a problem and continuing with the release
- redoing the release as 3.2.2 add silencing baselining for this
release only
- redoing the release as 4.0.0

Thoughts?

Thanks,
Robert


Re: [VOTE] Release Apache Sling Dynamic Include 3.2.0

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Thu, Jun 18, 2020 at 1:37 PM Robert Munteanu <ro...@apache.org> wrote:
> ...Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2283/ ..

I'm getting an error from the maven baseline plugin when trying to
build this from
org.apache.sling.dynamic-include-3.2.0-source-release.zip

[WARNING] Could not transfer metadata
org.apache.sling:org.apache.sling.dynamic-include/maven-metadata.xml
from/to apache.releases.https
(https://repository.apache.org/service/local/staging/deploy/maven2):
Failed to transfer file
https://repository.apache.org/service/local/staging/deploy/maven2/org/apache/sling/org.apache.sling.dynamic-include/maven-metadata.xml
with status code 400
[INFO] The baseline version was found to be 3.1.6
[ERROR] The bundle version change (3.1.6 to 3.2.0) is too low, the new
version must be at least 4.0.0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.626 s
[INFO] Finished at: 2020-06-22T12:37:22+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
biz.aQute.bnd:bnd-baseline-maven-plugin:4.2.0:baseline (bnd-baseline)
on project org.apache.sling.dynamic-include: An error occurred while
calculating the baseline: The baselining plugin detected versioning
errors -> [Help 1]

Am I doing something wrong?

-Bertrand

Re: [VOTE] Release Apache Sling Dynamic Include 3.2.0

Posted by Nicolas Peltier <np...@apache.org>.
+1

Le ven. 19 juin 2020 à 18:55, Andreas Schaefer <sc...@me.com.invalid> a
écrit :

> +1 (non-binding)
>
> - Andy
>
> > On Jun 18, 2020, at 4:37 AM, Robert Munteanu <ro...@apache.org> wrote:
> >
> > Hi,
> >
> > We solved 5 issues in this release:
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12346080
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2283/
> >
> > You can use this UNIX script to download the release and verify the
> signatures:
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2283 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Regards,
> > Robert Munteanu
>
>

Re: [VOTE] Release Apache Sling Dynamic Include 3.2.0

Posted by Andreas Schaefer <sc...@me.com.INVALID>.
+1 (non-binding)

- Andy

> On Jun 18, 2020, at 4:37 AM, Robert Munteanu <ro...@apache.org> wrote:
> 
> Hi,
> 
> We solved 5 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12346080
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2283/
> 
> You can use this UNIX script to download the release and verify the signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2283 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards,
> Robert Munteanu


Re: [VOTE] Release Apache Sling Dynamic Include 3.2.0

Posted by Robert Munteanu <ro...@apache.org>.
On Thu, 2020-06-18 at 11:37 +0000, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert

Re: [VOTE] Release Apache Sling Dynamic Include 3.2.0

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Thu, Jun 18, 2020 at 1:37 PM Robert Munteanu <ro...@apache.org> wrote:
> ...Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2283/...

+1 for the release of

org.apache.sling.dynamic-include-3.2.0-source-release.zip
sha1 : ed1765f28f363f8390a33f73b736a227664711fe

Checked signatures and build, which needs the workaround described at
SLING-8987 ( -Dbnd.baseline.skip ).

-Bertrand

[RESULT] [VOTE] Release Apache Sling Dynamic Include 3.2.0

Posted by Robert Munteanu <ro...@apache.org>.
Hi,

The vote has passed with the following result:

+1 (binding): Robert Munteanu, Nicolas Peltier, Bertrand Delacretaz
+1 (non-binding): Andreas Schaefer

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu


Re: [VOTE] Release Apache Sling Dynamic Include 3.2.0

Posted by Robert Munteanu <ro...@apache.org>.
We need one more binding votes for this release to go through.

Thanks,
Robert

On Thu, 2020-06-18 at 11:37 +0000, Robert Munteanu wrote:
> Hi,
> 
> We solved 5 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12346080
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2283/
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2283 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards,
> Robert Munteanu