You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/06/24 02:22:12 UTC

Review Request 35813: Removing GC executor code.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/
-----------------------------------------------------------

Review request for Aurora, Bill Farner and Brian Wickman.


Bugs: AURORA-1333
    https://issues.apache.org/jira/browse/AURORA-1333


Repository: aurora


Description
-------

Removing GC executor code.


Diffs
-----

  api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
  api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
  debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
  debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
  docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
  examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
  src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
  src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
  src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
  src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
  src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
  src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
  src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
  src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
  src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
  src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
  src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
  src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
  src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
  src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
  src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
  src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
  src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
  src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
  src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 

Diff: https://reviews.apache.org/r/35813/diff/


Testing
-------


Thanks,

Maxim Khutornenko

Re: Review Request 35813: Removing GC executor code.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89108
-----------------------------------------------------------

Ship it!


Master (4b8c34c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
>     https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing GC executor code.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89214
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Wickman


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
>     https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing GC executor code.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

Posted by Maxim Khutornenko <ma...@apache.org>.

> On June 24, 2015, 12:31 a.m., Brian Wickman wrote:
> > slightly overzealous deleting.  the thermos gc stuff should still be part of the thermos toolchain.
> 
> Maxim Khutornenko wrote:
>     Should not we rather rely on task reconciliation to do any cleanup instead? Force GCing a task does not seem to be a critical feature (in fact it's currently broken AURORA-1347) but comes with a maintenance burden. Is there a particular reason to hold on to it?

Actually meant "task reconciliation + mesos slave GC" above.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89104
-----------------------------------------------------------


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
>     https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing GC executor code.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

Posted by Kevin Sweeney <ke...@apache.org>.

> On June 23, 2015, 5:31 p.m., Brian Wickman wrote:
> > slightly overzealous deleting.  the thermos gc stuff should still be part of the thermos toolchain.
> 
> Maxim Khutornenko wrote:
>     Should not we rather rely on task reconciliation to do any cleanup instead? Force GCing a task does not seem to be a critical feature (in fact it's currently broken AURORA-1347) but comes with a maintenance burden. Is there a particular reason to hold on to it?
> 
> Maxim Khutornenko wrote:
>     Actually meant "task reconciliation + mesos slave GC" above.
> 
> Brian Wickman wrote:
>     if it's currently broken, then kill it with fire.

+1, and close https://issues.apache.org/jira/browse/AURORA-1347 as wontfix


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89104
-----------------------------------------------------------


On June 23, 2015, 5:22 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 5:22 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
>     https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing GC executor code.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

Posted by Brian Wickman <wi...@apache.org>.

> On June 24, 2015, 12:31 a.m., Brian Wickman wrote:
> > slightly overzealous deleting.  the thermos gc stuff should still be part of the thermos toolchain.
> 
> Maxim Khutornenko wrote:
>     Should not we rather rely on task reconciliation to do any cleanup instead? Force GCing a task does not seem to be a critical feature (in fact it's currently broken AURORA-1347) but comes with a maintenance burden. Is there a particular reason to hold on to it?
> 
> Maxim Khutornenko wrote:
>     Actually meant "task reconciliation + mesos slave GC" above.

if it's currently broken, then kill it with fire.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89104
-----------------------------------------------------------


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
>     https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing GC executor code.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

Posted by Maxim Khutornenko <ma...@apache.org>.

> On June 24, 2015, 12:31 a.m., Brian Wickman wrote:
> > slightly overzealous deleting.  the thermos gc stuff should still be part of the thermos toolchain.

Should not we rather rely on task reconciliation to do any cleanup instead? Force GCing a task does not seem to be a critical feature (in fact it's currently broken AURORA-1347) but comes with a maintenance burden. Is there a particular reason to hold on to it?


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89104
-----------------------------------------------------------


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
>     https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing GC executor code.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89104
-----------------------------------------------------------


slightly overzealous deleting.  the thermos gc stuff should still be part of the thermos toolchain.


src/main/python/apache/thermos/cli/commands/BUILD 
<https://reviews.apache.org/r/35813/#comment141702>

    same



src/main/python/apache/thermos/cli/main.py 
<https://reviews.apache.org/r/35813/#comment141701>

    no need to delete this.  'thermos gc' is a separate, valid command.


- Brian Wickman


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
>     https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing GC executor code.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89380
-----------------------------------------------------------

Ship it!


Master (d28bd4f) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On June 25, 2015, 4:59 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 4:59 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
>     https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing GC executor code.
> 
> 
> Diffs
> -----
> 
>   NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/
-----------------------------------------------------------

(Updated June 25, 2015, 4:59 p.m.)


Review request for Aurora, Bill Farner and Brian Wickman.


Changes
-------

Updated NEWS.


Bugs: AURORA-1333
    https://issues.apache.org/jira/browse/AURORA-1333


Repository: aurora


Description
-------

Removing GC executor code.


Diffs (updated)
-----

  NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
  api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
  api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
  debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
  debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
  docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
  examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
  src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
  src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
  src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
  src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
  src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
  src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
  src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
  src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
  src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
  src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
  src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
  src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
  src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
  src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
  src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
  src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
  src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
  src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
  src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 

Diff: https://reviews.apache.org/r/35813/diff/


Testing
-------


Thanks,

Maxim Khutornenko

Re: Review Request 35813: Removing GC executor code.

Posted by Maxim Khutornenko <ma...@apache.org>.

> On June 25, 2015, 4:34 p.m., Bill Farner wrote:
> > 25 files changed, 2 insertions(+), 2054 deletions(-)
> > 
> > Nice!  2 requests:
> > 
> > - Can you confirm that end-to-end tests still pass?
> > - Can you add to this patch a note in NEWS under 0.9.0 that the GC executor has been removed?

I ran e2e tests before posting this diff.

News section updated.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89372
-----------------------------------------------------------


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
>     https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing GC executor code.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35813: Removing GC executor code.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89372
-----------------------------------------------------------

Ship it!


25 files changed, 2 insertions(+), 2054 deletions(-)

Nice!  2 requests:

- Can you confirm that end-to-end tests still pass?
- Can you add to this patch a note in NEWS under 0.9.0 that the GC executor has been removed?

- Bill Farner


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
>     https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing GC executor code.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588 
>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>