You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Vladimir Strugatsky (JIRA)" <ji...@apache.org> on 2016/11/17 21:20:58 UTC

[jira] [Commented] (LUCENE-5929) Standard highlighting doesn't work for ToParentBlockJoinQuery

    [ https://issues.apache.org/jira/browse/LUCENE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674844#comment-15674844 ] 

Vladimir Strugatsky commented on LUCENE-5929:
---------------------------------------------

[~mikichi] - My understanding is that the fields you are highlighting need to be in a parent document, and that there is no support for highlighting fields in a child document. This JIRA fixed a bug with Highlighting of parent fields when using a Block Join Parser.

> Standard highlighting doesn't work for ToParentBlockJoinQuery
> -------------------------------------------------------------
>
>                 Key: LUCENE-5929
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5929
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/highlighter
>            Reporter: Julie Tibshirani
>            Assignee: Michael McCandless
>            Priority: Critical
>             Fix For: 5.0, 6.0
>
>         Attachments: HighligherTest.patch, LUCENE-5929.patch, LUCENE-5929.patch
>
>
> Because WeightedSpanTermExtractor#extract doesn't check for ToParentBlockJoinQuery, the Highlighter class fails to produce highlights for this type of query.
> At first it may seem like there's no issue, because ToParentBlockJoinQuery only returns parent documents, while the highlighting applies to children. But if a client can directly supply the text from child documents (as elasticsearch does if _source is enabled), then highlighting will unexpectedly fail.
> A test case that triggers the bug is attached. The same issue exists for ToChildBlockJoinQuery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org