You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by kkhatua <gi...@git.apache.org> on 2018/04/19 23:34:34 UTC
[GitHub] drill pull request #1229: DRILL-6333: Fixed Quotation marks
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/1229
DRILL-6333: Fixed Quotation marks
Initial step to making the source-code ready for Javadoc generation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkhatua/drill DRILL-6333
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1229
----
commit 82099e1bbeb455417b88d1dccaf7463fc0aecb88
Author: Kunal Khatua <kk...@...>
Date: 2018-04-05T07:17:55Z
DRILL-6333: Fixed Quotation marks
Initial step to making the source-code ready for Javadoc generation
----
---
[GitHub] drill issue #1229: DRILL-6333: Fixed Quotation marks
Posted by vdiravka <gi...@git.apache.org>.
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1229
@kkhatua These quotation marks are in `drill-java-exec package`.
There are some more italics quotation marks in the project. They are in
`package-info.java`, `TestScripts.java`, `USAGE.md` files from `drill-yarn` and `vector` package.
Do we want to edit them as well?
---
[GitHub] drill issue #1229: DRILL-6333: Fixed Quotation marks
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1229
Fixed it. I missed these because I detected the original issues when attempting to create javadocs for `java-exec` , `jdbc` and `jdbc-all` packages only. A search-and-replace in the entire Drill repo caught the rest.
@Ben-Zvi / @vdiravka can you guys do a quick scan to review this?
---
[GitHub] drill issue #1229: DRILL-6333: Fixed Quotation marks
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1229
I think we should. Let me walk through the entire project to be doubly sure. I'll correct them accordingly and resubmit a squashed commit..
Thanks for catching this, @vdiravka !
---
[GitHub] drill pull request #1229: DRILL-6333: Fixed Quotation marks
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1229
---