[GitHub] [incubator-yunikorn-k8shim] yangwwei edited a comment on pull request #202: [YUNIKORN-449] Added MatchNodeSelectorPred to reservation predicates list

[GitBox <gi...@apache.org>]

yangwwei edited a comment on pull request #202:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/202#issuecomment-717377672


   Hi @kingamarton thanks for testing this out. 
   > so I extended the predicate list for the default scheduling policy as well.
   
   If this is added to the `defaultSchedulerPolicy` list, it will be overlapping with `predicates.GeneralPred`. If you follow the code traces, you'll see `predicates.GeneralPred` calls `PodMatchNodeSelector`. That means while it tries to `predicatesAllocate()`, it runs the node-selector twice.
   
   I guess we need to fix some other way round. The problem you met might be caused by the CLI parser. Please take a look at https://github.com/apache/incubator-yunikorn-k8shim/pull/64. It adds the support to give a configurable list of predicates in CLI options. I think the fix here is, when the CLI is not providing any input, the default ones should come from both `defaultSchedulerPolicy` and `reservationPredicates`. Please let me know your thought about this.
   
   Thanks
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org