[GitHub] [airflow] uranusjr commented on a diff in pull request #31642: Protect having work task upstream of setup/teardown task context manager

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #31642:
URL: https://github.com/apache/airflow/pull/31642#discussion_r1212462668


##########
airflow/utils/setup_teardown.py:
##########
@@ -110,25 +110,49 @@ def push_setup_teardown_task(cls, operator: Operator | list[Operator]):
             if first_task.is_teardown:
                 if not all(task.is_teardown == first_task.is_teardown for task in operator):
                     raise ValueError("All tasks in the list must be either setup or teardown tasks")
+                upstream_tasks = [task for task in first_task.upstream_list]

Review Comment:
   There is another in the `else` block as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org