You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/05 03:11:27 UTC

[GitHub] [incubator-nuttx] anchao opened a new pull request #435: net: move the _SF*/_SS* definitions to net.h

anchao opened a new pull request #435: net: move the _SF*/_SS* definitions to net.h
URL: https://github.com/apache/incubator-nuttx/pull/435
 
 
   Build break caused by 23b8b397999136c61b3c834956ad1da55fb0e072
   
   Change-Id: I4a63ede90fbe3385423a9d88ae811cd596491fec
   Signed-off-by: chao.an <an...@xiaomi.com>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #435: net: move the _SF*/_SS* definitions to net.h

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #435: net: move the _SF*/_SS* definitions to net.h
URL: https://github.com/apache/incubator-nuttx/pull/435#issuecomment-595066419
 
 
   Yes, this is also our target: the modularity is very important for NuttX.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #435: net: move the _SF*/_SS* definitions to net.h

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #435: net: move the _SF*/_SS* definitions to net.h
URL: https://github.com/apache/incubator-nuttx/pull/435#discussion_r388057713
 
 

 ##########
 File path: include/nuttx/net/net.h
 ##########
 @@ -59,6 +59,32 @@
  * Pre-processor Definitions
  ****************************************************************************/
 
+/* Definitions of 8-bit socket flags */
 
 Review comment:
   Move after line 110, so all socket flag in one location

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #435: net: move the _SF*/_SS* definitions to net.h

Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #435: net: move the _SF*/_SS* definitions to net.h
URL: https://github.com/apache/incubator-nuttx/pull/435#discussion_r388059848
 
 

 ##########
 File path: include/nuttx/net/net.h
 ##########
 @@ -59,6 +59,32 @@
  * Pre-processor Definitions
  ****************************************************************************/
 
+/* Definitions of 8-bit socket flags */
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #435: net: move the _SF*/_SS* definitions to net.h

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #435: net: move the _SF*/_SS* definitions to net.h
URL: https://github.com/apache/incubator-nuttx/pull/435#issuecomment-595013758
 
 
   Thanks!  I am very happy to have that resolved satisfactorily.  I think there is an issue with mixing network socket knowledge inside of the scheduler task start-up logic.  That is not a clean separation of functionality.  But neither is mixing knowledge of the the file descriptor structures.  So we are really no worse than before.
   
   It is very important to keep the strict modularity of the OS internal design.  That is the only way that this OS can survive into the future without degenerating into an unmaintainable mass of spaghetti code.  We are not doing a very good job of enforcing the architecture.. I am not doing a good job either.  We need more people with the capability to review internal OS changes and with a good understanding of the modularity objectives.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo merged pull request #435: net: move the _SF*/_SS* definitions to net.h

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #435: net: move the _SF*/_SS* definitions to net.h
URL: https://github.com/apache/incubator-nuttx/pull/435
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services