You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "chmelevskij (via GitHub)" <gi...@apache.org> on 2025/12/02 09:55:02 UTC
[PR] fix(dashboard): embedded dashboard box sizing [superset]
chmelevskij opened a new pull request, #36375:
URL: https://github.com/apache/superset/pull/36375
### SUMMARY
Added correct `box-sizing` for embedded dashboard elements. This fixes overlaps when embedding.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="2592" height="866" alt="Screenshot 2025-12-02 at 10 45 21" src="https://github.com/user-attachments/assets/32449082-09c7-45e7-ad0b-f388a394bd3f" />
After:
<img width="2536" height="744" alt="Screenshot 2025-12-02 at 10 43 57" src="https://github.com/user-attachments/assets/cbaf3ca4-2537-45c1-8644-4f0d469b3771" />
### TESTING INSTRUCTIONS
Embed one of the dashboards in external application.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #36204 #35900 #34830
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): embedded dashboard box sizing [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #36375:
URL: https://github.com/apache/superset/pull/36375#issuecomment-3604308580
Just catching up on the thread in https://github.com/apache/superset/issues/36204#issuecomment-3600945189 - that seems to have a more scoped approach to the styling, if it happens to work. ¯\\\_(ツ)_/¯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): embedded dashboard box sizing [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #36375: fix(dashboard): embedded dashboard box sizing
URL: https://github.com/apache/superset/pull/36375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): embedded dashboard box sizing [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #36375:
URL: https://github.com/apache/superset/pull/36375#issuecomment-4456286382
Circling back: #38351 landed in March with the same universal `box-sizing: border-box` reset, but applied only to the embedded route via a `<Global>` style. That scopes it cleanly without touching any non-embedded code path, which addresses the "scope it tighter" concern from earlier.
Closing as superseded — thanks for the great write-up on #36204, the discussion there fed into the eventual fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): embedded dashboard box sizing [superset]
Posted by "chmelevskij (via GitHub)" <gi...@apache.org>.
chmelevskij commented on PR #36375:
URL: https://github.com/apache/superset/pull/36375#issuecomment-3611549630
> If that's true about using border-box in the same way, shouldn't that make things work already?
I'm assuming that's a question about `Layout`. Ant design `Layout` is only used for the main application, but not for embedded.
I've looked if it's possible to add `Layout` but it doesn't seem to fit the usecase, or at least would need way much more rethinking to get it work.
I will update it to scope to `.dashboar` thne.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): embedded dashboard box sizing [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #36375:
URL: https://github.com/apache/superset/pull/36375#issuecomment-3608269182
If that's true about <Layout> using border-box in the same way, shouldn't that make things work already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): embedded dashboard box sizing [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36375:
URL: https://github.com/apache/superset/pull/36375#issuecomment-3601174240
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org