[GitHub] [hadoop] cnauroth commented on a diff in pull request #5335: YARN-11426. Improve YARN NodeLabel Memory Display.

["cnauroth (via GitHub)" <gi...@apache.org>]

cnauroth commented on code in PR #5335:
URL: https://github.com/apache/hadoop/pull/5335#discussion_r1094945678


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/api/records/TestResource.java:
##########
@@ -42,4 +42,70 @@ void testCastToIntSafely() {
         "Cast to Integer.MAX_VALUE if the long is greater than "
             + "Integer.MAX_VALUE");
   }
+
+  @Test
+  public void testResourceFormatted() {
+    // We set 10MB
+    String expectedResult1 = "<memory:10 MB, vCores:1>";
+    MockResource capability1 = new MockResource();
+    capability1.setMemory(10);
+    capability1.setVirtualCores(1);
+    assertEquals(capability1.toFormattedString(), expectedResult1);
+
+    // We set 1024 MB = 1GB
+    String expectedResult2 = "<memory:1 GB, vCores:1>";
+    MockResource capability2 = new MockResource();
+    capability2.setMemory(1024);
+    capability2.setVirtualCores(1);
+    assertEquals(capability2.toFormattedString(), expectedResult2);
+
+    // We set 1024 * 1024 MB = 1024 GB = 1TB
+    String expectedResult3 = "<memory:1 TB, vCores:1>";
+    MockResource capability3 = new MockResource();
+    capability3.setMemory(1024 * 1024);
+    capability3.setVirtualCores(1);
+    assertEquals(capability3.toFormattedString(), expectedResult3);
+
+    // We set 1024 * 1024 * 1024 MB = 1024 * 1024 GB = 1 * 1024 TB = 1 PB
+    String expectedResult4 = "<memory:1 PB, vCores:1>";
+    MockResource capability4 = new MockResource();
+    capability4.setMemory(1024 * 1024 * 1024);
+    capability4.setVirtualCores(1);
+    assertEquals(capability4.toFormattedString(), expectedResult4);
+  }
+
+  class MockResource extends Resource {

Review Comment:
   Could we switch to a Mockito mock to shorten this code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org