[jira] Commented: (MYFACES-1996) Implement JSF 2.0 logic at TODO #55

["Michael Concini (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637946#action_12637946 ] 

Michael Concini commented on MYFACES-1996:
------------------------------------------

I volunteer to work on this issue. 

> Implement JSF 2.0 logic at TODO #55
> -----------------------------------
>
>                 Key: MYFACES-1996
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1996
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Simon Lessard
>            Priority: Minor
>
> In class: javax.faces.context.FacesContext
> Implement: public void setRenderAll(boolean renderAll)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Setting phase id to APPLY_REQUEST_VALUES in UIXCommand.queuEvent when immediate attribute is set to true?

[Henry Saputra <he...@oracle.com>]

Hi All,

I saw from the Trinidad 1.2.8.1 branch UIXCommand.queueEvent the code 
looks like this:

  /**
   * <p>Intercept <code>queueEvent</code> and mark the phaseId for the
   * event to be <code>PhaseId.APPLY_REQUEST_VALUES</code> if the
   * <code>immediate</code> flag is true,
   * <code>PhaseId.INVOKE_APPLICATION</code> otherwise.</p>
   */
  @Override
  public void queueEvent(FacesEvent e)
  {
    if (this == e.getComponent() && ((e instanceof ActionEvent) || (e 
instanceof ReturnEvent)))
    {
      if (isImmediate())
      {
        e.setPhaseId(PhaseId.ANY_PHASE);
      }
      else
      {
        e.setPhaseId(PhaseId.INVOKE_APPLICATION);
      }
    }

    super.queueEvent(e);
  }

Based on JSF spec shouldnt be that for isImmediate() equals to true, the 
phaseId be set to APPLY_REQUEST_VALUES rather than ANY_PHASE?

Thanks,

Henry