[GitHub] [beam] lukecwik commented on a diff in pull request #25551: Swap to a random number generator that doesn't use atomics/synchronization on hot path

["lukecwik (via GitHub)" <gi...@apache.org>]

lukecwik commented on code in PR #25551:
URL: https://github.com/apache/beam/pull/25551#discussion_r1110469311


##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/data/PCollectionConsumerRegistry.java:
##########
@@ -393,89 +394,58 @@ public double getProgress() {
     }
   }
 
-  private static class SampleByteSizeDistribution<T> {
+  public static class SampleByteSizeDistribution<T> extends ElementByteSizeObserver {

Review Comment:
   ```suggestion
     private static class SampleByteSizeDistribution<T> extends ElementByteSizeObserver {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org