You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/05/05 19:21:30 UTC
[jira] Created: (THRIFT-485) Generated validate methods that
reference external thrift files' types are not referenced correctly
Generated validate methods that reference external thrift files' types are not referenced correctly
---------------------------------------------------------------------------------------------------
Key: THRIFT-485
URL: https://issues.apache.org/jira/browse/THRIFT-485
Project: Thrift
Issue Type: Bug
Components: Compiler (Ruby)
Affects Versions: 0.1, 0.2
Reporter: Bryan Duxbury
Fix For: 0.2
Attachments: thrift-485.patch
If you have an enum in one thrift file and a struct with a field of that enum in another thrift file, the generated ruby code will try to validate the field's value against the enum's class, but without the namespace, resulting in errors.
Also, I found one other place where we should use the fully qualified type name instead of just the type name - when rendering constants of a struct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-485) Generated validate methods that
reference external thrift files' types are not referenced correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-485:
---------------------------------
Patch Info: [Patch Available]
> Generated validate methods that reference external thrift files' types are not referenced correctly
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-485
> URL: https://issues.apache.org/jira/browse/THRIFT-485
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Affects Versions: 0.1, 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.2
>
> Attachments: thrift-485.patch
>
>
> If you have an enum in one thrift file and a struct with a field of that enum in another thrift file, the generated ruby code will try to validate the field's value against the enum's class, but without the namespace, resulting in errors.
> Also, I found one other place where we should use the fully qualified type name instead of just the type name - when rendering constants of a struct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-485) Generated validate methods that
reference external thrift files' types are not referenced correctly
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706125#action_12706125 ]
Kevin Clark commented on THRIFT-485:
------------------------------------
Looks like a good fix. +1
> Generated validate methods that reference external thrift files' types are not referenced correctly
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-485
> URL: https://issues.apache.org/jira/browse/THRIFT-485
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Affects Versions: 0.1, 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.2
>
> Attachments: thrift-485.patch
>
>
> If you have an enum in one thrift file and a struct with a field of that enum in another thrift file, the generated ruby code will try to validate the field's value against the enum's class, but without the namespace, resulting in errors.
> Also, I found one other place where we should use the fully qualified type name instead of just the type name - when rendering constants of a struct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-485) Generated validate methods that
reference external thrift files' types are not referenced correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-485.
--------------------------------
Resolution: Fixed
Committed.
> Generated validate methods that reference external thrift files' types are not referenced correctly
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-485
> URL: https://issues.apache.org/jira/browse/THRIFT-485
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Affects Versions: 0.1, 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.2
>
> Attachments: thrift-485.patch
>
>
> If you have an enum in one thrift file and a struct with a field of that enum in another thrift file, the generated ruby code will try to validate the field's value against the enum's class, but without the namespace, resulting in errors.
> Also, I found one other place where we should use the fully qualified type name instead of just the type name - when rendering constants of a struct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-485) Generated validate methods that
reference external thrift files' types are not referenced correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-485:
---------------------------------
Attachment: thrift-485.patch
This should take care of the issue.
> Generated validate methods that reference external thrift files' types are not referenced correctly
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-485
> URL: https://issues.apache.org/jira/browse/THRIFT-485
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Affects Versions: 0.1, 0.2
> Reporter: Bryan Duxbury
> Fix For: 0.2
>
> Attachments: thrift-485.patch
>
>
> If you have an enum in one thrift file and a struct with a field of that enum in another thrift file, the generated ruby code will try to validate the field's value against the enum's class, but without the namespace, resulting in errors.
> Also, I found one other place where we should use the fully qualified type name instead of just the type name - when rendering constants of a struct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-485) Generated validate methods that
reference external thrift files' types are not referenced correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-485:
------------------------------------
Assignee: Bryan Duxbury
> Generated validate methods that reference external thrift files' types are not referenced correctly
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-485
> URL: https://issues.apache.org/jira/browse/THRIFT-485
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Affects Versions: 0.1, 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.2
>
> Attachments: thrift-485.patch
>
>
> If you have an enum in one thrift file and a struct with a field of that enum in another thrift file, the generated ruby code will try to validate the field's value against the enum's class, but without the namespace, resulting in errors.
> Also, I found one other place where we should use the fully qualified type name instead of just the type name - when rendering constants of a struct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.