You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by "mlycore (via GitHub)" <gi...@apache.org> on 2023/11/18 03:54:55 UTC

[PR] refactor: optimize backup return message while cancelled [shardingsphere-on-cloud]

mlycore opened a new pull request, #468:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/468

   <!-- Please answer these questions before submitting a pull request -->
   
   ### Type of change:
   
   <!-- Please delete options that are not relevant. -->
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   - [x] Refactor
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   - Reduce unnecessary log messages while the backup is cancelled.
   
   ### Pre-submission checklist:
   
   <!--
   Please follow the requirements:
   1. Test is required for the feat/fix PR, unless you have a good reason
   2. Doc is required for the feat PR
   3. Use "request review" to notify the reviewer once you have resolved the review
   -->
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: optimize backup return message while cancelled [shardingsphere-on-cloud]

Posted by "sandynz (via GitHub)" <gi...@apache.org>.

sandynz merged PR #468:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: optimize backup return message while cancelled [shardingsphere-on-cloud]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #468:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/468#issuecomment-1817361752

   ## [Codecov](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: `810 lines` in your changes are missing coverage. Please review.
   > Comparison is base [(`3604a24`)](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/commit/3604a24a625493b81e938f0ef40d1ba2793e2efb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 39.71% compared to head [(`18931f3`)](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 36.70%.
   > Report is 206 commits behind head on main.
   
   | [Files](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...phere-operator/pkg/controllers/chaos\_controller.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL2NoYW9zX2NvbnRyb2xsZXIuZ28=) | 0.00% | [276 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...perator/pkg/controllers/storage\_node\_controller.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL3N0b3JhZ2Vfbm9kZV9jb250cm9sbGVyLmdv) | 26.58% | [96 Missing and 20 partials :warning: ](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...operator/pkg/controllers/auto\_scaler\_controller.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL2F1dG9fc2NhbGVyX2NvbnRyb2xsZXIuZ28=) | 0.00% | [89 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pitr/cli/internal/cmd/delete.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl0ci9jbGkvaW50ZXJuYWwvY21kL2RlbGV0ZS5nbw==) | 61.41% | [38 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pitr/agent/internal/pkg/opengauss.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl0ci9hZ2VudC9pbnRlcm5hbC9wa2cvb3BlbmdhdXNzLmdv) | 2.56% | [38 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pitr/cli/internal/cmd/backup.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl0ci9jbGkvaW50ZXJuYWwvY21kL2JhY2t1cC5nbw==) | 55.26% | [32 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ator/cmd/shardingsphere-operator/manager/option.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvY21kL3NoYXJkaW5nc3BoZXJlLW9wZXJhdG9yL21hbmFnZXIvb3B0aW9uLmdv) | 6.06% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pitr/cli/internal/pkg/local-storage.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl0ci9jbGkvaW50ZXJuYWwvcGtnL2xvY2FsLXN0b3JhZ2UuZ28=) | 22.58% | [14 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ere-operator/pkg/kubernetes/container/container.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2t1YmVybmV0ZXMvY29udGFpbmVyL2NvbnRhaW5lci5nbw==) | 31.25% | [22 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [shardingsphere-operator/pkg/kubernetes/helpers.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2t1YmVybmV0ZXMvaGVscGVycy5nbw==) | 46.15% | [20 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [12 more](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main     #468      +/-   ##
   ==========================================
   - Coverage   39.71%   36.70%   -3.01%     
   ==========================================
     Files          51       61      +10     
     Lines        6083     6813     +730     
   ==========================================
   + Hits         2416     2501      +85     
   - Misses       3448     4069     +621     
   - Partials      219      243      +24     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/468?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: optimize backup return message while cancelled [shardingsphere-on-cloud]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.

sonarcloud[bot] commented on PR #468:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/468#issuecomment-1817361043

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=468)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=468&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=468) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=468&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=468&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org