You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/05 17:26:24 UTC

[GitHub] [airflow] dimberman commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file

dimberman commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S pod to be configured from JSON/YAML file
URL: https://github.com/apache/airflow/pull/6230#discussion_r331754671
 
 

 ##########
 File path: airflow/executors/kubernetes_executor.py
 ##########
 @@ -45,199 +47,6 @@
 MAX_LABEL_LEN = 63
 
 
-class KubeConfig:  # pylint: disable=too-many-instance-attributes
 
 Review comment:
   @davlum Could you move the Kubeconfig back and just make that a seperate PR? I'll get that merged quickly once this one goes through. I think with front-facing changes it better to put refactors in separately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services