You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2021/10/09 03:28:52 UTC
[GitHub] [openmeetings] sebawagner opened a new pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
sebawagner opened a new pull request #160:
URL: https://github.com/apache/openmeetings/pull/160
Makes it better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #160:
URL: https://github.com/apache/openmeetings/pull/160#discussion_r725424919
##########
File path: openmeetings-web/src/main/webapp/css/raw-menu.css
##########
@@ -1,6 +1,8 @@
/* Licensed under the Apache License, Version 2.0 (the "License") http://www.apache.org/licenses/LICENSE-2.0 */
#menu .navbar {
+ padding-top: 0;
Review comment:
It adds some padding-top when Wickets scss is applied. So setting this to 0 here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #160:
URL: https://github.com/apache/openmeetings/pull/160#discussion_r725424943
##########
File path: openmeetings-web/src/main/webapp/css/raw-menu.css
##########
@@ -1,6 +1,8 @@
/* Licensed under the Apache License, Version 2.0 (the "License") http://www.apache.org/licenses/LICENSE-2.0 */
#menu .navbar {
+ padding-top: 0;
padding-bottom: 0;
+ height: var(--room-menu-height);
Review comment:
Its a fixed height. Its not changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a change in pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #160:
URL: https://github.com/apache/openmeetings/pull/160#discussion_r725771720
##########
File path: openmeetings-web/src/main/webapp/css/raw-variables.css
##########
@@ -44,7 +44,7 @@ body.no-menu {
}
.main.room {
--header-height: 0px;
- --room-menu-height: calc(22px + 1rem);
+ --room-menu-height: 40px;
Review comment:
Bootstrap menu has font-size of `1rem`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #160:
URL: https://github.com/apache/openmeetings/pull/160#discussion_r725424919
##########
File path: openmeetings-web/src/main/webapp/css/raw-menu.css
##########
@@ -1,6 +1,8 @@
/* Licensed under the Apache License, Version 2.0 (the "License") http://www.apache.org/licenses/LICENSE-2.0 */
#menu .navbar {
+ padding-top: 0;
Review comment:
It adds some padding-top when Wickets scss is applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #160:
URL: https://github.com/apache/openmeetings/pull/160#discussion_r725788092
##########
File path: openmeetings-web/src/main/webapp/css/raw-variables.css
##########
@@ -44,7 +44,7 @@ body.no-menu {
}
.main.room {
--header-height: 0px;
- --room-menu-height: calc(22px + 1rem);
+ --room-menu-height: 40px;
Review comment:
As far as I can see the height of the element is fixed to 40px. So it doesn't matter what the font size is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #160:
URL: https://github.com/apache/openmeetings/pull/160#discussion_r725424862
##########
File path: openmeetings-web/src/main/webapp/css/raw-variables.css
##########
@@ -44,7 +44,7 @@ body.no-menu {
}
.main.room {
--header-height: 0px;
- --room-menu-height: calc(22px + 1rem);
+ --room-menu-height: 40px;
Review comment:
There is no need to calc 1rem. Its 40px. Its not going to be anything else inside the conference room.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #160:
URL: https://github.com/apache/openmeetings/pull/160#discussion_r725424943
##########
File path: openmeetings-web/src/main/webapp/css/raw-menu.css
##########
@@ -1,6 +1,8 @@
/* Licensed under the Apache License, Version 2.0 (the "License") http://www.apache.org/licenses/LICENSE-2.0 */
#menu .navbar {
+ padding-top: 0;
padding-bottom: 0;
+ height: var(--room-menu-height);
Review comment:
The menu in the conference room is a fixed height. Its not changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a change in pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #160:
URL: https://github.com/apache/openmeetings/pull/160#discussion_r729965357
##########
File path: openmeetings-web/src/main/webapp/css/raw-variables.css
##########
@@ -44,7 +44,7 @@ body.no-menu {
}
.main.room {
--header-height: 0px;
- --room-menu-height: calc(22px + 1rem);
+ --room-menu-height: 40px;
Review comment:
OK :)
I do remember it was on purpose, but unfortunately I can't remember correct steps for this :(
Let it be `40px` we can fix it any time later :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #160:
URL: https://github.com/apache/openmeetings/pull/160#discussion_r725424512
##########
File path: openmeetings-web/src/main/webapp/css/raw-room.css
##########
@@ -32,7 +32,7 @@
left: 0;
}
.room-block .sb-wb .sidebar #room-sidebar-tabs {
- height: calc(100% - var(--buffer-size) - var(--activities-height));
+ height: calc(100% - var(--activities-height));
Review comment:
Adding buffer here just adds even more white margin on the bottom of the activities tab. It doesn't help to add this buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #160:
URL: https://github.com/apache/openmeetings/pull/160#discussion_r725424512
##########
File path: openmeetings-web/src/main/webapp/css/raw-room.css
##########
@@ -32,7 +32,7 @@
left: 0;
}
.room-block .sb-wb .sidebar #room-sidebar-tabs {
- height: calc(100% - var(--buffer-size) - var(--activities-height));
+ height: calc(100% - var(--activities-height));
Review comment:
Adding buffer her just adds even more white margin on the bottom of the activities tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #160:
URL: https://github.com/apache/openmeetings/pull/160#discussion_r725424943
##########
File path: openmeetings-web/src/main/webapp/css/raw-menu.css
##########
@@ -1,6 +1,8 @@
/* Licensed under the Apache License, Version 2.0 (the "License") http://www.apache.org/licenses/LICENSE-2.0 */
#menu .navbar {
+ padding-top: 0;
padding-bottom: 0;
+ height: var(--room-menu-height);
Review comment:
The menu in the conference room is a fixed height. Its not changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner merged pull request #160: OPENMEETINGS-2681 Improve margins and when whiteboard is disabled.
Posted by GitBox <gi...@apache.org>.
sebawagner merged pull request #160:
URL: https://github.com/apache/openmeetings/pull/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org