You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ismailsimsek (via GitHub)" <gi...@apache.org> on 2025/01/09 11:09:19 UTC
[PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
ismailsimsek opened a new pull request, #11936:
URL: https://github.com/apache/iceberg/pull/11936
resolves #10844
resolves #11914
cc: @bryanck could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2665414155
> I did a pass about `LICENSE`/`NOTICE`.
>
> First, in `kafka-connect-transforms`, I see use of `debezium` package, but for specific code (not code copied from debezium), so it's OK.
>
> As `kafka-connect-transforms` is used in `kafka-connect-runtime` distributions, I did a pass on the transitive dependencies. Here's what I see in the PR:
>
> 1. The versions in `LICENSE` doesn't match the one in the distributions (I suggest to do a rebase to fix that)
>
> 2. `bson` should be in `LICENSE`. As bson comes from https://github.com/mongodb/mongo-java-driver and there's no `NOTICE` there, no need to update `NOTICE` in the distributions. That should be in this PR.
>
> 3. `detector-resources-support` (from Google Opentelemetry) and `exporter-metrics` (from Google Opentelemetry) are not in `LICENSE`. I will check that (on `main`) as I think I fixed it already.
>
>
> So, @ismailsimsek specifically to this PR, `bson` should be added in `LICENSE`. If you want I can create a commit in this PR for that.
Thanks for the review, @jbonofre, I appreciate your feedback. yep its ok for me, feel free to commit it directly to the PR, otherwise I can incorporate them soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1937001977
##########
kafka-connect/kafka-connect-transforms/README.md:
##########
@@ -0,0 +1,185 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one
+ - or more contributor license agreements. See the NOTICE file
+ - distributed with this work for additional information
+ - regarding copyright ownership. The ASF licenses this file
+ - to you under the Apache License, Version 2.0 (the
+ - "License"); you may not use this file except in compliance
+ - with the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing,
+ - software distributed under the License is distributed on an
+ - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ - KIND, either express or implied. See the License for the
+ - specific language governing permissions and limitations
+ - under the License.
+ -->
+
+# SMTs for the Apache Iceberg Sink Connector
Review Comment:
added it to "Kafka Connect" page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1931235657
##########
kafka-connect/kafka-connect-transforms/README.md:
##########
@@ -0,0 +1,185 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one
+ - or more contributor license agreements. See the NOTICE file
+ - distributed with this work for additional information
+ - regarding copyright ownership. The ASF licenses this file
+ - to you under the Apache License, Version 2.0 (the
+ - "License"); you may not use this file except in compliance
+ - with the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing,
+ - software distributed under the License is distributed on an
+ - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ - KIND, either express or implied. See the License for the
+ - specific language governing permissions and limitations
+ - under the License.
+ -->
+
+# SMTs for the Apache Iceberg Sink Connector
Review Comment:
@bryanck I feel like this should get moved to the docs pages, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1918978023
##########
kafka-connect/build.gradle:
##########
@@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
}
+
+project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') {
Review Comment:
Yes LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2662786358
@Fokko @bryanck @danielcweeks @jbonofre could you please review?
Currently, i believe only open question is on LICENSE/NOTICE changes, not sure what to do on that part. should we merge and followup with the new PR for LICENSE/NOTICE updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2582546815
@jbonofre @bryanck its ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1917185969
##########
gradle/libs.versions.toml:
##########
@@ -100,6 +101,7 @@ avro-avro = { module = "org.apache.avro:avro", version.ref = "avro" }
awssdk-bom = { module = "software.amazon.awssdk:bom", version.ref = "awssdk-bom" }
awssdk-s3accessgrants = { module = "software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin", version.ref = "awssdk-s3accessgrants" }
azuresdk-bom = { module = "com.azure:azure-sdk-bom", version.ref = "azuresdk-bom" }
+bson = { module = "org.mongodb:bson", version.ref = "bson-ver"}
Review Comment:
We need to verify this addition is captured in LICENSE/NOTICE files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1908636466
##########
kafka-connect/build.gradle:
##########
@@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
}
+
+project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') {
+ dependencies {
+ implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
+ implementation libs.bson
+// implementation libs.slf4j //TODO DISABLED! do we need this??
Review Comment:
commented out this. not sure if its needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1926899274
##########
gradle/libs.versions.toml:
##########
@@ -159,6 +161,7 @@ jaxb-runtime = { module = "org.glassfish.jaxb:jaxb-runtime", version.ref = "jaxb
kafka-clients = { module = "org.apache.kafka:kafka-clients", version.ref = "kafka" }
kafka-connect-api = { module = "org.apache.kafka:connect-api", version.ref = "kafka" }
kafka-connect-json = { module = "org.apache.kafka:connect-json", version.ref = "kafka" }
+kafka-connect-transforms = { module = "org.apache.kafka:connect-transforms", version.ref = "kafka" }
Review Comment:
@bryanck do you mean remove all grade setting/changes from this PR and add it with separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2678790403
It is OK with me if we lose my history. Could you look into the failing tests though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1920238659
##########
gradle/libs.versions.toml:
##########
@@ -159,6 +161,7 @@ jaxb-runtime = { module = "org.glassfish.jaxb:jaxb-runtime", version.ref = "jaxb
kafka-clients = { module = "org.apache.kafka:kafka-clients", version.ref = "kafka" }
kafka-connect-api = { module = "org.apache.kafka:connect-api", version.ref = "kafka" }
kafka-connect-json = { module = "org.apache.kafka:connect-json", version.ref = "kafka" }
+kafka-connect-transforms = { module = "org.apache.kafka:connect-transforms", version.ref = "kafka" }
Review Comment:
You can remove this too for now, until we add the transforms to the runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1920237916
##########
gradle/libs.versions.toml:
##########
@@ -100,6 +101,7 @@ avro-avro = { module = "org.apache.avro:avro", version.ref = "avro" }
awssdk-bom = { module = "software.amazon.awssdk:bom", version.ref = "awssdk-bom" }
awssdk-s3accessgrants = { module = "software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin", version.ref = "awssdk-s3accessgrants" }
azuresdk-bom = { module = "com.azure:azure-sdk-bom", version.ref = "azuresdk-bom" }
+bson = { module = "org.mongodb:bson", version.ref = "bson-ver"}
Review Comment:
I think we can remove it until we add the transform library to the runtime. When we do that, then the new license plugin can add what is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1918980035
##########
LICENSE:
##########
@@ -334,4 +334,24 @@ This product includes code from Apache Flink.
Copyright: 1999-2022 The Apache Software Foundation.
Home page: https://flink.apache.org/
-License: https://www.apache.org/licenses/LICENSE-2.0
\ No newline at end of file
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes software developed at The Apache Software Foundation.
+
+Apache Kafka (kafka-clients, kafka-connect-api, kafka-connect-json, kafka-connect-transforms)
+
+Copyright: 1999-2022 The Apache Software Foundation.
+Home page: https://kafka.apache.org/
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes software developed by MongoDB, Inc.
+
+* MongoDB BSON (bson)
+
+Copyright: 2008-present MongoDB, Inc.
+Home page: https://www.mongodb.com/
+License: https://github.com/mongodb/mongo-java-driver/blob/main/LICENSE.txt
Review Comment:
You shouldn't modify the root LICENSE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2666286092
@jbonofre rebased and updated LICENSE file. please feel free commit/change if anything missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1924230721
##########
kafka-connect/build.gradle:
##########
@@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
}
+
+project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') {
+ dependencies {
+ implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
+ implementation libs.bson
+// implementation libs.slf4j //TODO DISABLED! do we need this??
Review Comment:
added it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1918965887
##########
kafka-connect/build.gradle:
##########
@@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
}
+
+project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') {
Review Comment:
It looks good! We'll want to merge this without squashing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1918977918
##########
gradle/libs.versions.toml:
##########
@@ -159,6 +161,7 @@ jaxb-runtime = { module = "org.glassfish.jaxb:jaxb-runtime", version.ref = "jaxb
kafka-clients = { module = "org.apache.kafka:kafka-clients", version.ref = "kafka" }
kafka-connect-api = { module = "org.apache.kafka:connect-api", version.ref = "kafka" }
kafka-connect-json = { module = "org.apache.kafka:connect-json", version.ref = "kafka" }
+kafka-connect-transforms = { module = "org.apache.kafka:connect-transforms", version.ref = "kafka" }
Review Comment:
added section for kafka libs to LICENSE
##########
gradle/libs.versions.toml:
##########
@@ -100,6 +101,7 @@ avro-avro = { module = "org.apache.avro:avro", version.ref = "avro" }
awssdk-bom = { module = "software.amazon.awssdk:bom", version.ref = "awssdk-bom" }
awssdk-s3accessgrants = { module = "software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin", version.ref = "awssdk-s3accessgrants" }
azuresdk-bom = { module = "com.azure:azure-sdk-bom", version.ref = "azuresdk-bom" }
+bson = { module = "org.mongodb:bson", version.ref = "bson-ver"}
Review Comment:
added section for mongodb bson libs to LICENSE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1916919842
##########
kafka-connect/build.gradle:
##########
@@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
}
+
+project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') {
Review Comment:
It would be great to keep the history. [Here](https://stackoverflow.com/questions/1365541/how-to-move-some-files-from-one-git-repo-to-another-not-a-clone-preserving-hi) is one way you can do it. I think you'd need to start over and re-apply the package name change, but I think it might be worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1920242587
##########
kafka-connect/build.gradle:
##########
@@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
}
+
+project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') {
+ dependencies {
+ implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
+ implementation libs.bson
+// implementation libs.slf4j //TODO DISABLED! do we need this??
Review Comment:
This is a direct dependency so should not be commented out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1918996729
##########
LICENSE:
##########
@@ -334,4 +334,24 @@ This product includes code from Apache Flink.
Copyright: 1999-2022 The Apache Software Foundation.
Home page: https://flink.apache.org/
-License: https://www.apache.org/licenses/LICENSE-2.0
\ No newline at end of file
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes software developed at The Apache Software Foundation.
+
+Apache Kafka (kafka-clients, kafka-connect-api, kafka-connect-json, kafka-connect-transforms)
+
+Copyright: 1999-2022 The Apache Software Foundation.
+Home page: https://kafka.apache.org/
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes software developed by MongoDB, Inc.
+
+* MongoDB BSON (bson)
+
+Copyright: 2008-present MongoDB, Inc.
+Home page: https://www.mongodb.com/
+License: https://github.com/mongodb/mongo-java-driver/blob/main/LICENSE.txt
Review Comment:
@bryanck should it be the NOTICE file instead? `bson` is using `implementation` scope? is it then included with the distribution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1918981834
##########
LICENSE:
##########
@@ -334,4 +334,24 @@ This product includes code from Apache Flink.
Copyright: 1999-2022 The Apache Software Foundation.
Home page: https://flink.apache.org/
-License: https://www.apache.org/licenses/LICENSE-2.0
\ No newline at end of file
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes software developed at The Apache Software Foundation.
+
+Apache Kafka (kafka-clients, kafka-connect-api, kafka-connect-json, kafka-connect-transforms)
+
+Copyright: 1999-2022 The Apache Software Foundation.
+Home page: https://kafka.apache.org/
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes software developed by MongoDB, Inc.
+
+* MongoDB BSON (bson)
+
+Copyright: 2008-present MongoDB, Inc.
+Home page: https://www.mongodb.com/
+License: https://github.com/mongodb/mongo-java-driver/blob/main/LICENSE.txt
Review Comment:
Given this isn't yet being included in the runtime, we don't necessarily need to add anything to the runtime LICENSE until we add it to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1909022386
##########
kafka-connect/build.gradle:
##########
@@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
}
+
+project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') {
Review Comment:
Question, what is the recommended way to keep the commit history of previous committers? using co author feature?
as is git history and previous commiters are not copied over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1920238659
##########
gradle/libs.versions.toml:
##########
@@ -159,6 +161,7 @@ jaxb-runtime = { module = "org.glassfish.jaxb:jaxb-runtime", version.ref = "jaxb
kafka-clients = { module = "org.apache.kafka:kafka-clients", version.ref = "kafka" }
kafka-connect-api = { module = "org.apache.kafka:connect-api", version.ref = "kafka" }
kafka-connect-json = { module = "org.apache.kafka:connect-json", version.ref = "kafka" }
+kafka-connect-transforms = { module = "org.apache.kafka:connect-transforms", version.ref = "kafka" }
Review Comment:
I think we can skip that too for now, until we add the transforms to the runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2665354438
I did a pass about `LICENSE`/`NOTICE`.
First, in `kafka-connect-transforms`, I see use of `debezium` package, but for specific code (not code copied from debezium), so it's OK.
As `kafka-connect-transforms` is used in `kafka-connect-runtime` distributions, I did a pass on the transitive dependencies.
Here's what I see in the PR:
1. The versions in `LICENSE` doesn't match the one in the distributions (I suggest to do a rebase to fix that)
2. `bson` should be in `LICENSE`. As bson comes from https://github.com/mongodb/mongo-java-driver and there's no `NOTICE` there, no need to update `NOTICE` in the distributions. That should be in this PR.
3. `detector-resources-support` (from Google Opentelemetry) and `exporter-metrics` (from Google Opentelemetry) are not in `LICENSE`. I will check that (on `main`) as I think I fixed it already.
So, @ismailsimsek specifically to this PR, `bson` should be added in `LICENSE`. If you want I can create a commit in this PR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1937009495
##########
gradle/libs.versions.toml:
##########
@@ -159,6 +161,7 @@ jaxb-runtime = { module = "org.glassfish.jaxb:jaxb-runtime", version.ref = "jaxb
kafka-clients = { module = "org.apache.kafka:kafka-clients", version.ref = "kafka" }
kafka-connect-api = { module = "org.apache.kafka:connect-api", version.ref = "kafka" }
kafka-connect-json = { module = "org.apache.kafka:connect-json", version.ref = "kafka" }
+kafka-connect-transforms = { module = "org.apache.kafka:connect-transforms", version.ref = "kafka" }
Review Comment:
in that case i have reverted all the changes done to LICENSE/NOTICE files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1917186435
##########
gradle/libs.versions.toml:
##########
@@ -159,6 +161,7 @@ jaxb-runtime = { module = "org.glassfish.jaxb:jaxb-runtime", version.ref = "jaxb
kafka-clients = { module = "org.apache.kafka:kafka-clients", version.ref = "kafka" }
kafka-connect-api = { module = "org.apache.kafka:connect-api", version.ref = "kafka" }
kafka-connect-json = { module = "org.apache.kafka:connect-json", version.ref = "kafka" }
+kafka-connect-transforms = { module = "org.apache.kafka:connect-transforms", version.ref = "kafka" }
Review Comment:
We need to verify this addition is captured in LICENSE/NOTICE files (if separate from the other kafka dependencies)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1917177902
##########
kafka-connect/build.gradle:
##########
@@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
}
+
+project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') {
Review Comment:
@bryanck updated it could you please check it now?
##########
kafka-connect/build.gradle:
##########
@@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
}
+
+project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') {
Review Comment:
@bryanck updated it could you please check it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1918976352
##########
kafka-connect/build.gradle:
##########
@@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
}
+
+project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') {
Review Comment:
ok squashed last commits together to have clean history. hope its ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1926899274
##########
gradle/libs.versions.toml:
##########
@@ -159,6 +161,7 @@ jaxb-runtime = { module = "org.glassfish.jaxb:jaxb-runtime", version.ref = "jaxb
kafka-clients = { module = "org.apache.kafka:kafka-clients", version.ref = "kafka" }
kafka-connect-api = { module = "org.apache.kafka:connect-api", version.ref = "kafka" }
kafka-connect-json = { module = "org.apache.kafka:connect-json", version.ref = "kafka" }
+kafka-connect-transforms = { module = "org.apache.kafka:connect-transforms", version.ref = "kafka" }
Review Comment:
@bryanck do you mean remove all grade setting/changes and add it with separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1909022386
##########
kafka-connect/build.gradle:
##########
@@ -242,3 +243,19 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
}
+
+project(':iceberg-kafka-connect:iceberg-kafka-connect-transforms') {
Review Comment:
Question, what is the recommended way to keep the commit history or previous committers? using co author feature?
as is git history and previous commiters are not copied over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2596353766
Thanks @ismailsimsek for porting this over!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1931239440
##########
kafka-connect/kafka-connect-transforms/README.md:
##########
@@ -0,0 +1,185 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one
+ - or more contributor license agreements. See the NOTICE file
+ - distributed with this work for additional information
+ - regarding copyright ownership. The ASF licenses this file
+ - to you under the Apache License, Version 2.0 (the
+ - "License"); you may not use this file except in compliance
+ - with the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing,
+ - software distributed under the License is distributed on an
+ - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ - KIND, either express or implied. See the License for the
+ - specific language governing permissions and limitations
+ - under the License.
+ -->
+
+# SMTs for the Apache Iceberg Sink Connector
Review Comment:
Yes that makes sense to me, we should remove this README and move the content to the docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2662805005
@ismailsimsek let me do a pass and suggest update on LICENSE/NOTICE if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2678973458
@ismailsimsek I created a PR to "fix" the `LICENSE`/`NOTICE`: https://github.com/ismailsimsek/iceberg/pull/201 Maybe worth to consider ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2682720586
Thanks @ismailsimsek for porting this over!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1918977023
##########
LICENSE:
##########
@@ -334,4 +334,24 @@ This product includes code from Apache Flink.
Copyright: 1999-2022 The Apache Software Foundation.
Home page: https://flink.apache.org/
-License: https://www.apache.org/licenses/LICENSE-2.0
\ No newline at end of file
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes software developed at The Apache Software Foundation.
+
+Apache Kafka (kafka-clients, kafka-connect-api, kafka-connect-json, kafka-connect-transforms)
+
+Copyright: 1999-2022 The Apache Software Foundation.
+Home page: https://kafka.apache.org/
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes software developed by MongoDB, Inc.
+
+* MongoDB BSON (bson)
+
+Copyright: 2008-present MongoDB, Inc.
+Home page: https://www.mongodb.com/
+License: https://github.com/mongodb/mongo-java-driver/blob/main/LICENSE.txt
Review Comment:
@danielcweeks is this look ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1918996729
##########
LICENSE:
##########
@@ -334,4 +334,24 @@ This product includes code from Apache Flink.
Copyright: 1999-2022 The Apache Software Foundation.
Home page: https://flink.apache.org/
-License: https://www.apache.org/licenses/LICENSE-2.0
\ No newline at end of file
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes software developed at The Apache Software Foundation.
+
+Apache Kafka (kafka-clients, kafka-connect-api, kafka-connect-json, kafka-connect-transforms)
+
+Copyright: 1999-2022 The Apache Software Foundation.
+Home page: https://kafka.apache.org/
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes software developed by MongoDB, Inc.
+
+* MongoDB BSON (bson)
+
+Copyright: 2008-present MongoDB, Inc.
+Home page: https://www.mongodb.com/
+License: https://github.com/mongodb/mongo-java-driver/blob/main/LICENSE.txt
Review Comment:
@bryanck should it be the NOTICE file instead? `bson` is using `implementation` scope? is it then included with the distribution?
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "liko9 (via GitHub)" <gi...@apache.org>.
liko9 commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2661037022
Can someone please add this to the milestone for 1.9.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1931238829
##########
gradle/libs.versions.toml:
##########
@@ -159,6 +161,7 @@ jaxb-runtime = { module = "org.glassfish.jaxb:jaxb-runtime", version.ref = "jaxb
kafka-clients = { module = "org.apache.kafka:kafka-clients", version.ref = "kafka" }
kafka-connect-api = { module = "org.apache.kafka:connect-api", version.ref = "kafka" }
kafka-connect-json = { module = "org.apache.kafka:connect-json", version.ref = "kafka" }
+kafka-connect-transforms = { module = "org.apache.kafka:connect-transforms", version.ref = "kafka" }
Review Comment:
I meant skip any of the runtime license changes, until we add the transforms lib to the runtime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2666290041
@ismailsimsek awesome ! thanks. I'm preparing a PR for your branch 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2679174636
@jbonofre merge it and test are passing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck merged PR #11936:
URL: https://github.com/apache/iceberg/pull/11936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2679185228
LGTM, I'll leave it open for one more day and see if there is any more feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Kafka Connect: Add SMTs for Debezium and AWS DMS [iceberg]
Posted by "ismailsimsek (via GitHub)" <gi...@apache.org>.
ismailsimsek commented on PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2678012549
@jbonofre @danielcweeks @Fokko @ajantha-bhat could you please review? I believe all open points are addressed.
Note: We'll want to merge this without squashing.
> It looks good! We'll want to merge this without squashing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org