You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Ivan (JIRA)" <ji...@apache.org> on 2010/05/07 10:36:47 UTC

[jira] Created: (GERONIMO-5287) Felix instance cache is not cleared for client/shutdown/deploy

Felix instance cache is not cleared for client/shutdown/deploy
--------------------------------------------------------------

                 Key: GERONIMO-5287
                 URL: https://issues.apache.org/jira/browse/GERONIMO-5287
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: osgi
    Affects Versions: 3.0
            Reporter: Ivan
             Fix For: 3.0


On my windows box, after the deployment, I found the instance cache folder in the var folder is not not deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-5287) Felix instance cache is not cleared for client/shutdown/deploy

Posted by "Rick McGuire (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rick McGuire updated GERONIMO-5287:
-----------------------------------

    Fix Version/s: 3.0-M1
                       (was: 3.0)

> Felix instance cache is not cleared for client/shutdown/deploy
> --------------------------------------------------------------
>
>                 Key: GERONIMO-5287
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5287
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi
>    Affects Versions: 3.0
>            Reporter: Ivan
>            Assignee: Jarek Gawor
>             Fix For: 3.0-M1
>
>         Attachments: GERONIMO-5287.patch
>
>
> On my windows box, after the deployment, I found the instance cache folder in the var folder is not not deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-5287) Felix instance cache is not cleared for client/shutdown/deploy

Posted by "Ivan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan updated GERONIMO-5287:
---------------------------

    Attachment: GERONIMO-5287.patch

I created a patch, including changes below :
a. Wait the framework stop
b. Do not stop deleting if one file is failed to delete
With the patch, most of files could be deleted, except for a jline.dll. I guess that the classloader loads it is not destoryed yet ...

> Felix instance cache is not cleared for client/shutdown/deploy
> --------------------------------------------------------------
>
>                 Key: GERONIMO-5287
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5287
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi
>    Affects Versions: 3.0
>            Reporter: Ivan
>             Fix For: 3.0
>
>         Attachments: GERONIMO-5287.patch
>
>
> On my windows box, after the deployment, I found the instance cache folder in the var folder is not not deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5287) Felix instance cache is not cleared for client/shutdown/deploy

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865187#action_12865187 ] 

Jarek Gawor commented on GERONIMO-5287:
---------------------------------------

In revision 942094 I committed your changes to the Utils.recursiveDelete() function. I think that will largely solve this problem. I also have some outstanding patches to Karaf that might resolve the jline.dll issue.



> Felix instance cache is not cleared for client/shutdown/deploy
> --------------------------------------------------------------
>
>                 Key: GERONIMO-5287
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5287
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi
>    Affects Versions: 3.0
>            Reporter: Ivan
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>         Attachments: GERONIMO-5287.patch
>
>
> On my windows box, after the deployment, I found the instance cache folder in the var folder is not not deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5287) Felix instance cache is not cleared for client/shutdown/deploy

Posted by "Ivan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865377#action_12865377 ] 

Ivan commented on GERONIMO-5287:
--------------------------------

Hi, Jarek
    I am afraid that the codes for waiting framework stop are also required. From my understanding, the framework.stop() methods return immediately, it just initializes another thread to stop the framework. So while the codes in shutdwon hook are executed, some jars in the cache folder are still not closed. 

> Felix instance cache is not cleared for client/shutdown/deploy
> --------------------------------------------------------------
>
>                 Key: GERONIMO-5287
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5287
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi
>    Affects Versions: 3.0
>            Reporter: Ivan
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>         Attachments: GERONIMO-5287.patch
>
>
> On my windows box, after the deployment, I found the instance cache folder in the var folder is not not deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (GERONIMO-5287) Felix instance cache is not cleared for client/shutdown/deploy

Posted by "Ivan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan reopened GERONIMO-5287:
----------------------------


> Felix instance cache is not cleared for client/shutdown/deploy
> --------------------------------------------------------------
>
>                 Key: GERONIMO-5287
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5287
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi
>    Affects Versions: 3.0
>            Reporter: Ivan
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>         Attachments: GERONIMO-5287.patch
>
>
> On my windows box, after the deployment, I found the instance cache folder in the var folder is not not deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMO-5287) Felix instance cache is not cleared for client/shutdown/deploy

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved GERONIMO-5287.
-----------------------------------

    Resolution: Fixed

> Felix instance cache is not cleared for client/shutdown/deploy
> --------------------------------------------------------------
>
>                 Key: GERONIMO-5287
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5287
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi
>    Affects Versions: 3.0
>            Reporter: Ivan
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>         Attachments: GERONIMO-5287.patch
>
>
> On my windows box, after the deployment, I found the instance cache folder in the var folder is not not deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GERONIMO-5287) Felix instance cache is not cleared for client/shutdown/deploy

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor reassigned GERONIMO-5287:
-------------------------------------

    Assignee: Jarek Gawor

> Felix instance cache is not cleared for client/shutdown/deploy
> --------------------------------------------------------------
>
>                 Key: GERONIMO-5287
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5287
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi
>    Affects Versions: 3.0
>            Reporter: Ivan
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>         Attachments: GERONIMO-5287.patch
>
>
> On my windows box, after the deployment, I found the instance cache folder in the var folder is not not deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMO-5287) Felix instance cache is not cleared for client/shutdown/deploy

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved GERONIMO-5287.
-----------------------------------

    Resolution: Fixed

Ok. In revision 942833 I committed additional updates for this problem. The instance cache directory will be removed after the framework is fully stopped. Also, added a shutdown hook to stop the framework and delete the cache directory for cases like the application client container where the application client can call System.exit() directly.



> Felix instance cache is not cleared for client/shutdown/deploy
> --------------------------------------------------------------
>
>                 Key: GERONIMO-5287
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5287
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi
>    Affects Versions: 3.0
>            Reporter: Ivan
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>         Attachments: GERONIMO-5287.patch
>
>
> On my windows box, after the deployment, I found the instance cache folder in the var folder is not not deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.