You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2024/10/28 18:18:41 UTC
[PR] Document junk before function() SM 1.8.5 vs 78+ [couchdb]
nickva opened a new pull request, #5325:
URL: https://github.com/apache/couchdb/pull/5325
In SpiderMonkey 1.8.5 allow this type of syntax:
```
foo : function(doc){emit(doc._id, 1);}
```
While later versions started throwing a compilation error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document junk before function() SM 1.8.5 vs 78+ [couchdb]
Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #5325:
URL: https://github.com/apache/couchdb/pull/5325#discussion_r1826551650
##########
src/docs/src/best-practices/jsdevel.rst:
##########
@@ -247,6 +247,21 @@ might have emitted the "Invalid Date" string, while in later SpiderMonkey
engines all the emit results from that document will be skipped, since view
functions skip view results if an exception is thrown.
+9. Invalid JavaScript before function definition
+
+SpiderMoneky version ``1.8.5`` allowed the invalid ``term : function(...)``
Review Comment:
Typo: "SpiderMonkey"
##########
src/docs/src/best-practices/jsdevel.rst:
##########
@@ -247,6 +247,21 @@ might have emitted the "Invalid Date" string, while in later SpiderMonkey
engines all the emit results from that document will be skipped, since view
functions skip view results if an exception is thrown.
+9. Invalid JavaScript before function definition
+
+SpiderMoneky version ``1.8.5`` allowed the invalid ``term : function(...)``
+syntax. So a view function like the following worked and produced successfull
Review Comment:
Typo: "successful"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document junk before function() SM 1.8.5 vs 78+ [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #5325:
URL: https://github.com/apache/couchdb/pull/5325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org