You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2007/08/29 20:52:34 UTC
[jira] Created: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Configure RAT plugin to fail in case of missing licenses
--------------------------------------------------------
Key: WW-2147
URL: https://issues.apache.org/struts/browse/WW-2147
Project: Struts 2
Issue Type: Task
Components: Actions, API, Component Management, Configuration, Dispatch, Documentation, Expression Language, Integration, Interceptors, Misc, Plugins, Portlet Integration, Temp, Tests, Validation, Value Stack, Views
Affects Versions: 2.0.9
Reporter: Antonio Petrelli
Fix For: 2.0.11
The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown reopened WW-2147:
---------------------------
This should not have been closed until it was proven to work at least once. I've temporarily disabled the plugin as it reports too many errors to be regressions.
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.1
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Husted updated WW-2147:
---------------------------
Component/s: (was: Core Actions)
(was: "New" API)
(was: XML Configuration)
(was: Dispatch Filter)
(was: Documentation)
(was: Expression Language)
(was: Integration)
(was: Core Interceptors)
(was: Other)
(was: Plugin - Mechanism)
(was: Plugin - Portlet)
(was: Temp)
(was: Tests)
(was: Validation)
(was: Value Stack)
(was: Views)
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Fix For: 2.1.3
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli reassigned WW-2147:
------------------------------------
Assignee: Antonio Petrelli
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.3
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43628#action_43628 ]
Don Brown commented on WW-2147:
-------------------------------
Sure, but that should be done before the rat plugin was added that breaks the release build. Having the plugin isn't a blocker to a release, which I'm doing right now, and until someone has the time to "fix" the licenses or more accurately, review them to determine if they need to be fixed or not, I've uncommented the task. It is kind of like committing code that is "cleaner" but breaks the tests - the build should always be green. I'm modifying the Bamboo builds to run all the release profiles to ensure we catch this problem earlier next time.
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.2
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-2147:
--------------------------
Fix Version/s: (was: 2.0.11)
2.1.0
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Actions, API, Component Management, Configuration, Dispatch, Documentation, Expression Language, Integration, Interceptors, Misc, Plugins, Portlet Integration, Temp, Tests, Validation, Value Stack, Views
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Fix For: 2.1.0
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli reassigned WW-2147:
------------------------------------
Assignee: Antonio Petrelli
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.2
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43630#action_43630 ]
Don Brown commented on WW-2147:
-------------------------------
Ah, cool, glad to know. Hmm... I was getting some 631 errors or so, so I wonder what changed. I pushed this over to the next release, so hopefully someone can take a look at it. I changed the bamboo builds to run 'mvn clean package -P release,all,alljars,pre-assembly', so hopefully we should catch more issues before the release. I am happy that we have the rat plugin to automate the tedious process of checking licenses. I'll try to find some time after this release to see why those errors are being reported.
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Fix For: 2.1.2
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43627#action_43627 ]
Antonio Petrelli commented on WW-2147:
--------------------------------------
Sorry to bother, but won't be better to fix the unlicensed files?
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.2
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli resolved WW-2147.
----------------------------------
Resolution: Fixed
Fixed missing licenses.
Re-enabled RAT during build and fixed configuration.
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.2
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli reassigned WW-2147:
------------------------------------
Assignee: (was: Antonio Petrelli)
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Fix For: 2.1.2
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli closed WW-2147.
--------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.1.3)
2.1.1
Now the RAT check is run during release, so we cannot release unlicensed files.
This is true only for main code and plugins (for Dojo plugin, Dojo source code is excluded from the check).
The example apps are excluded from the check.
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.1
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43629#action_43629 ]
Antonio Petrelli commented on WW-2147:
--------------------------------------
In fact, when I added the RAT plugin, all the licenses were OK (I fixed them myself, see WW-2049).
Anyway, thanks for adding the release profile to Bamboo.
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.2
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2147) Configure RAT plugin to fail in case of
missing licenses
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-2147:
--------------------------
Fix Version/s: (was: 2.1.1)
2.1.2
> Configure RAT plugin to fail in case of missing licenses
> --------------------------------------------------------
>
> Key: WW-2147
> URL: https://issues.apache.org/struts/browse/WW-2147
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Affects Versions: 2.0.9
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.2
>
>
> The RAT plugin should be introduced to fail in case of missing or unapproved licenses.
> This plugin should be configured to work only during the release process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.